Closed Bug 648508 Opened 9 years ago Closed 9 years ago

Remove the Windows CE code for accelerometer support (follow up)

Categories

(Core :: DOM: Core & HTML, defect)

All
Windows CE
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla5

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Bug 644743 removed the WinCE code for accelerometer support, however there are a few remnants left of:

> #if !defined(WINCE) && !defined(WINCE_WINDOWS_MOBILE) // normal windows.

Since the #ifdef WINCE_WINDOWS_MOBILE cases have been removed; checking
for the opposite is now presumably redundant (see bug 644743 comment 4).
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attached patch Patch (v1)Splinter Review
This is my first patch, hopefully I've set up my hgrc correctly.

Ehsan, I don't have Try access - would you possibly mind vouching for level 1 so I can use try? ie per: http://www.mozilla.org/hacking/commit-access-policy/
Attachment #524610 - Flags: review?(jst)
Comment on attachment 524610 [details] [diff] [review]
Patch (v1)

Looks good! r=jst
Attachment #524610 - Flags: review?(jst) → review+
Thanks!
Keywords: checkin-needed
Pushed: http://hg.mozilla.org/mozilla-central/rev/6ff088b689a3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Thanks :-)
Keywords: checkin-needed
Target Milestone: --- → mozilla2.2
Whiteboard: [good first bug]
(In reply to comment #1)
> Ehsan, I don't have Try access - would you possibly mind vouching for level 1
> so I can use try? ie per: http://www.mozilla.org/hacking/commit-access-policy/

Of course!  Just file the bug and CC me.  And thanks for your patch!  :-)
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/dom/system/windows/
...returns 0 results.

-> Verified
Status: RESOLVED → VERIFIED
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.