Closed
Bug 648508
Opened 14 years ago
Closed 14 years ago
Remove the Windows CE code for accelerometer support (follow up)
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla5
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
2.33 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
Bug 644743 removed the WinCE code for accelerometer support, however there are a few remnants left of:
> #if !defined(WINCE) && !defined(WINCE_WINDOWS_MOBILE) // normal windows.
Since the #ifdef WINCE_WINDOWS_MOBILE cases have been removed; checking
for the opposite is now presumably redundant (see bug 644743 comment 4).
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → bmo
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
This is my first patch, hopefully I've set up my hgrc correctly.
Ehsan, I don't have Try access - would you possibly mind vouching for level 1 so I can use try? ie per: http://www.mozilla.org/hacking/commit-access-policy/
Assignee | ||
Updated•14 years ago
|
Attachment #524610 -
Flags: review?(jst)
Comment 2•14 years ago
|
||
Comment on attachment 524610 [details] [diff] [review]
Patch (v1)
Looks good! r=jst
Attachment #524610 -
Flags: review?(jst) → review+
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Target Milestone: --- → mozilla2.2
Assignee | ||
Updated•14 years ago
|
Whiteboard: [good first bug]
Comment 6•14 years ago
|
||
(In reply to comment #1)
> Ehsan, I don't have Try access - would you possibly mind vouching for level 1
> so I can use try? ie per: http://www.mozilla.org/hacking/commit-access-policy/
Of course! Just file the bug and CC me. And thanks for your patch! :-)
Assignee | ||
Comment 7•14 years ago
|
||
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/dom/system/windows/
...returns 0 results.
-> Verified
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•