645725 - Don't require two taps to open non-fullscreen landscape keyboard (e.g. Xoom)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Matt Brubeck (:mbrubeck)]

We currently require two taps in the urlbar before we will show the landscape keyboard (bug 593456).  This is useful when the landscape keyboard is full-screen and completely obscures the UI.

However, the landscape keyboard in Android 3.0 "Honeycomb" on the Motorola Xoom is not full-screen, so we should show it on the first tap.

Originally reported at https://support.mozilla.com/en-US/questions/801959

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I'd like to try to stop using the fullscreen keyboard too (bug 615778)

Comment 2

[Madhava Enros [:madhava]]

yes - on a tablet, definitely.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Do we have any way to tell if the keyboard is fullscreen or not?

If not, we'd need to make a whitelist of devices that use non-fullscreen keyboards in landscape. If bug 615778 is fixed for some devices, we'd need to add those devices to the whitelist too.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 536766 [details] [diff] [review]
patch

Can you make Utils.isKeyboardFullscreen() and use it here?

Looks good, just want to see the new patch.

Comment 6

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

Moved the new code to its own function.  I made this a private method of BrowserUI because it's not really useful outside of the main chrome window, and because I hope this code will go away if we manage to use non-fullscreen keyboard everywhere.

Comment 7

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/0526937cc481

Comment 8

[Matt Brubeck (:mbrubeck)]

Attachment: test fixes

This updates browser-chrome tests broken by this change, and fixes two unrelated permaoranges.

Comment 9

[Matt Brubeck (:mbrubeck)]

Comment on attachment 536997 [details] [diff] [review]
test fixes

http://hg.mozilla.org/mozilla-central/rev/a52b04dc29ea

Comment 10

[Tony Chung [:tchung]]

Verified fix on Motorola Xoom.  Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110610 Firefox/7.0a1 Fennec/7.0a1.   Single tap brings up half keyboard view.