Closed Bug 647414 Opened 13 years ago Closed 13 years ago

Distributed extensions should be automatically installed into temporary testing profile

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(status2.0 wontfix)

Status:
VERIFIED FIXED
Milestone:
mozilla6
Tracking Flags:
Tracking Status
status2.0 --- wontfix

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

(Keywords: autotest-issue)

Attachments

(3 files, 3 obsolete files)

(Cv1) Add ipc-overlay.xul to SeaMonkey too [Checked in: Comment 13]
2.77 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
(Av2) Improve addChromeToProfile() and related [Checked in: Comment 11]
8.29 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
(Bv3) Make installExtensionsToProfile() automatically install application distributed extensions [Checked in: Comment 12]
2.94 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
SeaMonkey includes 4 extensions: CZ, DebugQA, DOMi, Venkman.

Before bug 627240, they were installed in application directory and were always available in test suites.
After that bug, they are no longer available because they are not explicitly installed into temporary testing profile.

Bug 647404 will let us "manually" add
{
--install-extension=<appDir>/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi
--install-extension=<appDir>/distribution/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}.xpi
--install-extension=<appDir>/distribution/extensions/debugQA@mozilla.org.xpi
--install-extension=<appDir>/distribution/extensions/inspector@mozilla.org.xpi
}
when running locally or through buildbot steps.

But it would be even simpler if "test automation" installed all extensions present in <appDir>/distribution/extensions/, possibly just copying that whole tree.

What do you think?
status2.0: --- → ?
Keywords: autotest-issue
Let's sort out what we are really doing.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #523837 - Flags: review?(jmaher)
I guess installing a "same" custom extension as is distributed is not supported as is: that support can be checked/added later if need be.

NB: Bug 642983 will refactor these.
Attachment #523838 - Flags: review?(jmaher)
Depends on: 647404
Not exactly this bug, but that's another thing SeaMonkey misses too.
(SM probably didn't support IPC yet when bug 567417 landed.)
Attachment #523841 - Flags: review?(jmaher)
Depends on: 567417
Comment on attachment 523837 [details] [diff] [review]
(Av1) Improve addChromeToProfile() and related

thanks for the cleanup in runtests.py.
Attachment #523837 - Flags: review?(jmaher) → review+
Attachment #523838 - Flags: review?(jmaher) → review+
Comment on attachment 523841 [details] [diff] [review]
(Cv1) Add ipc-overlay.xul to SeaMonkey too
[Checked in: Comment 13]

the one caveat here is we are moving to specialpowers which will replace all of this code.
Attachment #523841 - Flags: review?(jmaher) → review+
Av1, further improved.
Attachment #523837 - Attachment is obsolete: true
Attachment #524824 - Flags: review?(jmaher)
Bv1, unbloated.
Attachment #523838 - Attachment is obsolete: true
Attachment #524825 - Flags: review?(jmaher)
Attachment #524825 - Flags: review?(jmaher) → review+
Comment on attachment 524824 [details] [diff] [review]
(Av2) Improve addChromeToProfile() and related
[Checked in: Comment 11]

a lot of changes here, does this pass on try server?  I did a sanity check locally and all is well.
Attachment #524824 - Flags: review?(jmaher) → review+
Bv2, fixed for "no 'distribution/extensions' directory" case (as with Firefox),
and for a ("profileDir") copy+paste issue in runreftest.py.
Attachment #524825 - Attachment is obsolete: true
Attachment #526047 - Flags: review?(jmaher)
(In reply to comment #8)
> a lot of changes here, does this pass on try server?

Right! With patch Bv3, this is now succeeding:
http://tbpl.mozilla.org/?tree=MozillaTry&rev=4a94bbd765fd
Attachment #526047 - Flags: review?(jmaher) → review+
Comment on attachment 524824 [details] [diff] [review]
(Av2) Improve addChromeToProfile() and related
[Checked in: Comment 11]

http://hg.mozilla.org/mozilla-central/rev/b9a9d3286722
Attachment #524824 - Attachment description: (Av2) Improve addChromeToProfile() and related → (Av2) Improve addChromeToProfile() and related [Checked in: Comment 11]
Comment on attachment 526047 [details] [diff] [review]
(Bv3) Make installExtensionsToProfile() automatically install application distributed extensions
[Checked in: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/6c32c1f15e21
Attachment #526047 - Attachment description: (Bv3) Make installExtensionsToProfile() automatically install application distributed extensions → (Bv3) Make installExtensionsToProfile() automatically install application distributed extensions [Checked in: Comment 12]
Comment on attachment 523841 [details] [diff] [review]
(Cv1) Add ipc-overlay.xul to SeaMonkey too
[Checked in: Comment 13]

http://hg.mozilla.org/mozilla-central/rev/e5499ca3c2da
Attachment #523841 - Attachment description: (Cv1) Add ipc-overlay.xul to SeaMonkey too → (Cv1) Add ipc-overlay.xul to SeaMonkey too [Checked in: Comment 13]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n to (m-aurora and) m-2.0, after bug 647404: patches Av2, Bv3, Cv1]
Target Milestone: --- → mozilla6
V.Fixed, per bug 647394 comment 11.
Status: RESOLVED → VERIFIED
Bug 647104 is wontfix on those branches, so this is too.
status2.0: ? → wontfix
Keywords: checkin-needed
Whiteboard: [c-n to (m-aurora and) m-2.0, after bug 647404: patches Av2, Bv3, Cv1]
(In reply to comment #15)
> Bug 647104 is wontfix on those branches, so this is too.

Err, bug 647404 !
Blocks: 717753
No longer blocks: 717753
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: