647414 - Distributed extensions should be automatically installed into temporary testing profile

Status: VERIFIED FIXED

(Testing :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

SeaMonkey includes 4 extensions: CZ, DebugQA, DOMi, Venkman.

Before bug 627240, they were installed in application directory and were always available in test suites.
After that bug, they are no longer available because they are not explicitly installed into temporary testing profile.

Bug 647404 will let us "manually" add
{
--install-extension=<appDir>/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi
--install-extension=<appDir>/distribution/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}.xpi
--install-extension=<appDir>/distribution/extensions/[e-mail]
--install-extension=<appDir>/distribution/extensions/[e-mail]
}
when running locally or through buildbot steps.

But it would be even simpler if "test automation" installed all extensions present in <appDir>/distribution/extensions/, possibly just copying that whole tree.

What do you think?

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Improve addChromeToProfile() and related

Let's sort out what we are really doing.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Make installExtensionsToProfile() automatically install distributed extensions

I guess installing a "same" custom extension as is distributed is not supported as is: that support can be checked/added later if need be.

NB: Bug 642983 will refactor these.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) Add ipc-overlay.xul to SeaMonkey too [Checked in: Comment 13]

Not exactly this bug, but that's another thing SeaMonkey misses too.
(SM probably didn't support IPC yet when bug 567417 landed.)

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 523837 [details] [diff] [review]
(Av1) Improve addChromeToProfile() and related

thanks for the cleanup in runtests.py.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 523841 [details] [diff] [review]
(Cv1) Add ipc-overlay.xul to SeaMonkey too
[Checked in: Comment 13]

the one caveat here is we are moving to specialpowers which will replace all of this code.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Improve addChromeToProfile() and related [Checked in: Comment 11]

Av1, further improved.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2) Make installExtensionsToProfile() automatically install application distributed extensions.

Bv1, unbloated.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 524824 [details] [diff] [review]
(Av2) Improve addChromeToProfile() and related
[Checked in: Comment 11]

a lot of changes here, does this pass on try server?  I did a sanity check locally and all is well.

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Bv3) Make installExtensionsToProfile() automatically install application distributed extensions [Checked in: Comment 12]

Bv2, fixed for "no 'distribution/extensions' directory" case (as with Firefox),
and for a ("profileDir") copy+paste issue in runreftest.py.

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> a lot of changes here, does this pass on try server?

Right! With patch Bv3, this is now succeeding:
http://tbpl.mozilla.org/?tree=MozillaTry&rev=4a94bbd765fd

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 524824 [details] [diff] [review]
(Av2) Improve addChromeToProfile() and related
[Checked in: Comment 11]

http://hg.mozilla.org/mozilla-central/rev/b9a9d3286722

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 526047 [details] [diff] [review]
(Bv3) Make installExtensionsToProfile() automatically install application distributed extensions
[Checked in: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/6c32c1f15e21

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 523841 [details] [diff] [review]
(Cv1) Add ipc-overlay.xul to SeaMonkey too
[Checked in: Comment 13]

http://hg.mozilla.org/mozilla-central/rev/e5499ca3c2da

Comment 14

[Serge Gautherie (:sgautherie)]

V.Fixed, per bug 647394 comment 11.

Comment 15

[Justin Wood (:Callek)]

Bug 647104 is wontfix on those branches, so this is too.

Comment 16

[Serge Gautherie (:sgautherie)]

(In reply to comment #15)
> Bug 647104 is wontfix on those branches, so this is too.

Err, bug 647404 !