649790 - [Release Channel] Unlabelled download buttons visible on Firefox/Future Releases download page when multiple locales offered

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot

Currently with Safari Version 5.0.4 (6533.20.27), on the following pages, I am seeing multiple download buttons, when there should only exist a single.

[1] http://www.mozilla.com/en-US/firefox
[2] http://www.mozilla.com/en-US/firefox/channel/

See screenshot attached.

Comment 1

[raymond [:retornam] (inactive)]

Attachment: screenshotSafari

I am not able to reproduce this on my version of safari

Comment 2

[Pascal Chevrel:pascalc]

I'd say this is the symptom of having javascript deactivated as we use javascript to hide/show the download box specific to your OS. If js is deactivated, we show the 3 download boxes. Usually we put a mention in the download boxes to indicate the OS for the download box, since we don't mention it on the channels page, it looks like the same box is repeated 3 times.

Comment 3

[raymond [:retornam] (inactive)]

(In reply to comment #2)
> I'd say this is the symptom of having javascript deactivated as we use
> javascript to hide/show the download box specific to your OS. If js is
> deactivated, we show the 3 download boxes. Usually we put a mention in the
> download boxes to indicate the OS for the download box, since we don't mention
> it on the channels page, it looks like the same box is repeated 3 times.

https://www.mozilla.com/en-US/firefox/channel/index.html currently does not show buttons with Javascript disabled. see bug 647678

Comment 4

[Aaron Train [:aaronmt]]

(In reply to comment #2)
> I'd say this is the symptom of having javascript deactivated as we use
> javascript to hide/show the download box specific to your OS. If js is
> deactivated, we show the 3 download boxes. Usually we put a mention in the
> download boxes to indicate the OS for the download box, since we don't mention
> it on the channels page, it looks like the same box is repeated 3 times.

I have JS enabled in the browser.

Comment 5

[Matthew N. [:MattN]]

For me this problem is caused by having multiple locales offered for download and therefore happens in other browsers as well (ie. Nightly for me).  The buttons don't specify the locale that they link to (like they do on the Firefox landing page).

Steps to reproduce:
1) Change your browser's Accept-Language headers to include en-CA (Canadian English). See Preferences -> Content -> Languages in Firefox.
2) Load https://www.mozilla.com/firefox/channel/

Expected Result:
A labelled button for each locale that is applicable to me

Actual Result:
Unlabelled buttons (which all link to en-US builds for Aurora)

Comment 7

[raymond [:retornam] (inactive)]

from bz's comment #17 in bug 650238

Yeah, this is a bug in the page.  The relevant code is:

function writeDownloadItems(aProduct)
{
  // Show the dynamic links
  if (gPlatform == PLATFORM_MAC) {
    document.writeln(gDownloadItemMacOS9);
  } else if (gPlatform == PLATFORM_OTHER) {
    document.writeln(gDownloadItemOtherPlatform);
  } else {
    var languageIDs = getLanguageIDs(aProduct);
    for (var i = 0; i < languageIDs.length; ++i)
      writeDownloadItem(languageIDs[i]);
  }
}

getLanguageIDs splits your navigator.language ("en-CA" in your case) on '-',
sets "languageCode" to "en", sets "regionCode" to "ca", and then does this:

  var currentVersion = gLanguages["en"]["us"][aProduct];
  var bestVersion = "";

  for (region in gLanguages[languageCode]) {
    build = gLanguages[languageCode][region];
    if (build[aProduct] && regionCode == region) {

That always tests false for the "fxaurora" product, say, because
gLanguages["en"]["ca"]["fxaurora"] is null.  Then we go on to:

    // We have a localized build for this language, but not this region.
    // Show all available regions and let the user pick.
    if (bestVersion != currentVersion) {

For Firefox, I see links to en-US, en-GB, and en-ZA builds as a result (but the
buttons don't say where they're going, of course).  But for Aurora, as you
noted they're all en-US.  And that's because getDownloadURLForLanguage calls
getDownloadURLForAuroraForLanguage in the "fxaurora" case and that last
function has:

  // Force en-US locale for now, when we fix other language replace it with
  // "locale"
  url += aProduct + "-" + aVersion + ".en-US." + os_file_ext;

So yeah, this page just needs fixing.

Comment 8

[Aaron Train [:aaronmt]]

Attachment: Safari v5.0.5

This is still an issue. Here is the download page for Firefox 5 via Safari Version 5.0.5 (6533.21.1)

Not seeing this in Chrome 14.0.798.0 (89674)

Comment 10

[Anthony Ricaud (:rik)]

Committed r92243 on trunk to fix this. I've added the locale name in the download buttons.

See on https://www-trunk.stage.mozilla.com/en-US/firefox/channel/

Comment 11

[Anthony Ricaud (:rik)]

Pushed to stage/production with r92273.

Comment 12

[raymond [:retornam] (inactive)]

(In reply to comment #11)
> Pushed to stage/production with r92273.

Aaron, please confirm that this is fixed thanks

Comment 13

[Aaron Train [:aaronmt]]

Attachment: Safari v5.0.5 (b)

https://www-trunk.stage.mozilla.com/en-US/firefox/channel/

Reopening as this is not fixed on Safari Version 5.0.5 (6533.21.1)

Comment 14

[Anthony Ricaud (:rik)]

This is on purpose. For "en" visitors with no build for their specific locale (en-CA has no specific build), we present the whole set of locales that fit the language.

For a Costa Rican visitor (es-CR), we present the four spanish locales we have.

So this looked fixed for me. If you feel we should do something else, please reopen and assign to :pascalc from web localisation and he'll help decide what is best for everyone.

Comment 15

[raymond [:retornam] (inactive)]

qa-verified-trunk https://www-trunk.stage.mozilla.com/en-US/firefox/channel/