The default bug view has changed. See this FAQ.

Change browser CSS based on Android OS version

VERIFIED FIXED in Firefox 6

Status

Fennec Graveyard
General
P1
enhancement
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: madhava, Assigned: mfinkle)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
Firefox 6
ARM
Android
Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
We'd like to be able to change the styling of the chrome based on what version of Android the user is running. Fitting in on Froyo will require a different look to fitting in on Gingerbread or (even more so) Honeycomb.
(Assignee)

Updated

6 years ago
Depends on: 650388
Depends on: 650390
Severity: normal → enhancement
tracking-firefox6: --- → ?
Priority: -- → P1
(Assignee)

Updated

6 years ago
Depends on: 380401
tracking-fennec: --- → 6+
Whiteboard: [fennec-6]
Created attachment 531235 [details] [diff] [review]
patch - base

This patch uses the newly landed osversion support for Android to create a gingerbread and honeycomb theme folders. The patch does not add any new CSS of images, just makes it easy to do that later.

Notes:
* Creating a 3 tiered theme system based on versions (froyo, gingerbread and honeycomb) is not as easy as it will be. For now, the middle tier (gingerbread) must have it's osversions explicitly named. We'll support ranged based operators in the future. For now, we know that gingerbread is 2.3, 2.3.3, 2.3.4
* The gingerbread and honeycomb folders only hold images for now. And only images I was fairly sure would change. The *.css files are reused from the default theme. As we need to override *.css files, we can add them to the gingerbread and honeycomb folders; and update the jar.mn file.
* Desktop builds will use the current (froyo theme)

The patch is big, but 99% is the images. The magic happens in jar.mn
Assignee: nobody → mark.finkle
Attachment #531235 - Flags: review?(mbrubeck)
Comment on attachment 531235 [details] [diff] [review]
patch - base

Two reviewers are better than one
Attachment #531235 - Flags: review?(21)
Comment on attachment 531235 [details] [diff] [review]
patch - base

As said on IRC I'm a bit worried about the impact on the size of the APK, many users are complaining about it (sigh)
Attachment #531235 - Flags: review?(21) → review+
Comment on attachment 531235 [details] [diff] [review]
patch - base

I agree with vingtetun's size concerns.  Especially for Froyo vs. Gingerbread, it might make more sense to share most of the CSS and assets, and just add overrides for the differences.
Attachment #531235 - Flags: review?(mbrubeck) → review+
(In reply to comment #4)

> I agree with vingtetun's size concerns.  Especially for Froyo vs.
> Gingerbread, it might make more sense to share most of the CSS and assets,
> and just add overrides for the differences.

Not opposed to sharing with caveats:
* Let's see what can be shared in the end
* Let's see what the change in size ends up being
* Don't make a complicated system to make it happen. I don't want multiple chrome skin URIs to worry about and maintain.
pushed:
http://hg.mozilla.org/mozilla-central/rev/aa889d945ef9

additional work will happen in the blocked bugs
Blocks: 653134, 653136
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 7

6 years ago
Verified fixed according to Tinderboxpushlog.
Status: RESOLVED → VERIFIED
(Assignee)

Updated

6 years ago
tracking-firefox6: ? → ---
(Assignee)

Updated

6 years ago
status-firefox6: --- → fixed
Target Milestone: --- → Firefox 6
No longer blocks: 653136
Blocks: 655762
You need to log in before you can comment on or make changes to this bug.