653136 - [meta] Create Fennec Honeycomb theme

Status: RESOLVED DUPLICATE of bug 655762

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

We should make design changes to the Fennec UI so that it fits in better on Android 3.0 (Honeycomb)

Related to Bug 653134 - Create Fennec Gingerbread theme, in that we should use the appropriate theming for a given version of Android.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Use the Gingerbread theme on Honeycomb

I think a logical first step for this would be to use the gingerbread theme on honeycomb.

The attached patch does so, and depends on bug #656329 and bug #664149

Comment 2

[[:fabrice] Fabrice Desré]

If this theme only applies to Android >= 3.0, we should rather do a separate theme, and refer to it in jar.mn :

http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/jar.mn#129

Comment 3

[Chris Lord [:cwiiis]]

Attachment: WIP: Implement a Honeycomb-specific theme

This patch applies over the first Gingerbread theme copying patch and modifies it to be a bit more Honeycomb-centric (colours, text-sizes, the URL bar). Work in progress.

Comment 4

[Mike Hommey [:glandium]]

Just a little note wrt the screenshot on http://twitpic.com/5mndb2 . It looks like a consistent UI thing in honeycomb applications is the top rightmost icon being the menu icon, which looks like the second on the right on the screenshot. For consistency with other applications, it might be better to put it at that place.

As a side note, please avoid duplicating files, it makes our footprint bigger than necessary.

Comment 5

[Chris Lord [:cwiiis]]

With respect to the menu button, this is just the styling and not the layout - though you can see why it's not at the end of the bar when you see the visual mock-ups here:

http://www.flickr.com/photos/61892693@N03/sets/72157626861654396/with/5786722517/

Also, with respect to duplicating files, most/all of these will be changing - we can sort out which ones are duplicated once the work is finished, but I doubt they'll be any left.

Comment 6

[Chris Lord [:cwiiis]]

Attachment: WIP: Implement a Honeycomb-specific theme

Slightly more thorough theme - this goes some way to themeing the settings panels.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Can we split this patch up into: "Just port the gingerbread theme to existing honeycomb" and "update the honeycomb theme to the new features added for honeycomb"

Comment 10

[Matt Brubeck (:mbrubeck)]

Merging this with bug 655762 where most of the honeycomb theme work is currently being tracked.