Closed Bug 649891 Opened 9 years ago Closed 9 years ago

500 Internal Server Error trying to load Fennec 4.0b5 /topcrasher lists /byversion

Categories

(Socorro :: General, task, P1)

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 650904

People

(Reporter: stephend, Assigned: rhelmer)

References

()

Details

STR:

1. Load https://crash-stats.stage.mozilla.com/topcrasher/byversion/Fennec/4.0b5/28/browser with the Web Console open
2. Wait
3. Examine the console

Actual Results:

[20:01:03.558] POST https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/cpu/Fennec/4.0b5/ [HTTP/1.1 500 Internal Server Error 31972ms]
[20:01:03.584] POST https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/addon/Fennec/4.0b5/ [HTTP/1.1 500 Internal Server Error 31897ms]
[20:01:03.608] POST https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/module/Fennec/4.0b5/ [HTTP/1.1 500 Internal Server Error 31856ms]
(Unlike the other Kohana ones, I think this is pretty important.)
Flags: in-testsuite?
Flags: in-litmus?
It looks like we don't currently generate correlation reports for Fennec, the list is hardcoded to Firefox Thunderbird SeaMonkey Camino:

http://code.google.com/p/socorro/source/browse/trunk/scripts/crons/cron_libraries.sh
So would the solution here be to add "Fennec" to the correlation generator script list? Or to have logic that evaluates whether or not the report is for Fennec, and removes the correlations tab in the UI for that specific product?

On spec this looks like a good candidate for general refactoring, especially if we're hoping to productize Socorro to some extent. Am I correct in my assumption that third party users would not be able to generate correlation reports without editing this file directly?
This will get refactored as part of bug 629029 soon anyway.

Stephen: do you want those 500 errors to go away before then?  If so let's do something hackish, like just not try to load correlation reports for products that don't have them.
Wrong bug number, doh.    Bug 629029 says we should spin off a bug to refactor correlation reports.  I'll file that next.

Bug 623164 will add correlation reports for Fennec, by the way.
(In reply to comment #5)
> Wrong bug number, doh.    Bug 629029 says we should spin off a bug to refactor
> correlation reports.  I'll file that next.
> 
> Bug 623164 will add correlation reports for Fennec, by the way.

Cool; does this depend on bug 623164 in any way, then?
(In reply to comment #6)
> (In reply to comment #5)
> > Wrong bug number, doh.    Bug 629029 says we should spin off a bug to refactor
> > correlation reports.  I'll file that next.
> > 
> > Bug 623164 will add correlation reports for Fennec, by the way.
> 
> Cool; does this depend on bug 623164 in any way, then?

Closing that will close this, so yes.  Mind if we punt this one until then?
Depends on: 623164
(In reply to comment #7)

> > Cool; does this depend on bug 623164 in any way, then?
> 
> Closing that will close this, so yes.  Mind if we punt this one until then?

Fine by me!
Target Milestone: 1.7.7 → 1.9
Does this also cover https://crash-stats.stage.mozilla.com/topcrasher/byversion/Firefox/4.0b13pre having:

[17:31:36.262] POST https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/cpu/Firefox/4.0b13pre/ [HTTP/1.1 500 Internal Server Error 31221ms]
[17:31:36.277] POST https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/addon/Firefox/4.0b13pre/ [HTTP/1.1 500 Internal Server Error 31195ms]
[17:31:36.292] POST https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/module/Firefox/4.0b13pre/ [HTTP/1.1 500 Internal Server Error 31170ms]

Are those just missing correlation reports?
(In reply to comment #9)
> Does this also cover
> https://crash-stats.stage.mozilla.com/topcrasher/byversion/Firefox/4.0b13pre
> having:
> 
> [17:31:36.262] POST
> https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/cpu/Firefox/4.0b13pre/
> [HTTP/1.1 500 Internal Server Error 31221ms]
> [17:31:36.277] POST
> https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/addon/Firefox/4.0b13pre/
> [HTTP/1.1 500 Internal Server Error 31195ms]
> [17:31:36.292] POST
> https://crash-stats.stage.mozilla.com/correlation/bulk_ajax/module/Firefox/4.0b13pre/
> [HTTP/1.1 500 Internal Server Error 31170ms]
> 
> Are those just missing correlation reports?

Yes looks like:

https://crash-analysis.mozilla.com/crash_analysis/20110418/

I think something we should fix though is to return HTTP 404, not 500 if the report is not found.
(In reply to comment #5)
> Wrong bug number, doh.    Bug 629029 says we should spin off a bug to refactor
> correlation reports.  I'll file that next.

Erm, I think that should be covered by bug 642325, right?
Assignee: nobody → rhelmer
Target Milestone: 1.9 → ---
Priority: -- → P1
Is this still happening? I just retested the query from comment 0 (using server name crash-stats.allizom.org instead of the old staging name), and I see no 500 errors in the web console.

Also spinners are replaced with "UNKNOWN: No Data" after  a short interval, due to bug 658034 being fixed.
(In reply to Robert Helmer [:rhelmer] from comment #12)
> Is this still happening? I just retested the query from comment 0 (using
> server name crash-stats.allizom.org instead of the old staging name), and I
> see no 500 errors in the web console.
> 
> Also spinners are replaced with "UNKNOWN: No Data" after  a short interval,
> due to bug 658034 being fixed.

It still happens on https://crash-stats-dev.allizom.org/topcrasher/byversion/Firefox/9.0a2/28/browser.
[09:56:13.436] POST https://crash-stats-dev.allizom.org/correlation/bulk_ajax/cpu/Firefox/9.0a2/ [HTTP/1.1 500 Internal Server Error 33443ms]
[09:56:13.440] POST https://crash-stats-dev.allizom.org/correlation/bulk_ajax/addon/Firefox/9.0a2/ [HTTP/1.1 500 Internal Server Error 33257ms]
[09:56:13.445] POST https://crash-stats-dev.allizom.org/correlation/bulk_ajax/module/Firefox/9.0a2/ [HTTP/1.1 500 Internal Server Error 33073ms]
(In reply to Stephen Donner [:stephend] from comment #13)
> (In reply to Robert Helmer [:rhelmer] from comment #12)
> > Is this still happening? I just retested the query from comment 0 (using
> > server name crash-stats.allizom.org instead of the old staging name), and I
> > see no 500 errors in the web console.
> > 
> > Also spinners are replaced with "UNKNOWN: No Data" after  a short interval,
> > due to bug 658034 being fixed.
> 
> It still happens on
> https://crash-stats-dev.allizom.org/topcrasher/byversion/Firefox/9.0a2/28/
> browser.

Aha, ok thanks for reproducing, will take a look.
Status: NEW → ASSIGNED
OK the problem here is that the zeus is timing out our request and returning HTTP 500, so lowering severity.

We have a bunch of interconnected bugs around correlation reports, I'll go through these and try to emerge with one or two that are actionable and make sense.
Severity: critical → normal
The way we do this now is just too slow, the zeus or PHP timeout is going to kill it.

We need to not be trying to download and parse these files on every page load.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 650904
Verified duplicate.
Status: RESOLVED → VERIFIED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.