The default bug view has changed. See this FAQ.

Panorama hangs when restoring a session

RESOLVED FIXED in Firefox 6

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 6
Dependency tree / graph
Bug Flags:
in-testsuite +

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Session restore re-uses (overwrites) opened tabs when restoring a session. Panorama closes all groups not present in the to-be-restored session. If those include re-used tabs, these tabs get closed and SR / Panorama wait until these (now closed) tabs get restored.
(Assignee)

Comment 1

6 years ago
Created attachment 526580 [details] [diff] [review]
patch v1

Changes:

* bug624727.js: disabling private browsing if it wasn't enabled caused this test to fail
* bug629195.js: the test must call setWindowState() with aOverwrite = true to meet the test's expectations

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=97fb08e090ab
Attachment #526580 - Flags: feedback?(raymond)
(Assignee)

Updated

6 years ago
Blocks: 636279
Comment on attachment 526580 [details] [diff] [review]
patch v1

Looks good
Attachment #526580 - Flags: feedback?(raymond) → feedback+
(Assignee)

Updated

6 years ago
Attachment #526580 - Flags: review?(ian)
(Assignee)

Comment 3

6 years ago
Created attachment 526651 [details] [diff] [review]
patch v2
Attachment #526580 - Attachment is obsolete: true
Attachment #526580 - Flags: review?(ian)
Attachment #526651 - Flags: review?(ian)
(Assignee)

Comment 4

6 years ago
Comment on attachment 526651 [details] [diff] [review]
patch v2

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=44ef323d64e9
(Assignee)

Comment 5

6 years ago
Created attachment 526749 [details] [diff] [review]
patch v3
Attachment #526651 - Attachment is obsolete: true
Attachment #526651 - Flags: review?(ian)
Attachment #526749 - Flags: review?(ian)
(Assignee)

Comment 6

6 years ago
Comment on attachment 526749 [details] [diff] [review]
patch v3

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=tim.taubert@gmx.de&rev=c3b827e1e649
(Assignee)

Updated

6 years ago
Blocks: 650280
(Assignee)

Updated

6 years ago
Blocks: 595020
Comment on attachment 526749 [details] [diff] [review]
patch v3

Paul, can you review this? I'm phasing out my review duties, and would like to spread the Panorama code knowledge around.
Attachment #526749 - Flags: review?(ian) → review?(paul)
(Assignee)

Updated

6 years ago
Blocks: 645461
(Assignee)

Updated

6 years ago
Blocks: 603789
(Assignee)

Updated

6 years ago
Blocks: 631952
(Assignee)

Updated

6 years ago
Blocks: 651643
(Assignee)

Updated

6 years ago
No longer blocks: 603789
(Assignee)

Updated

6 years ago
Blocks: 653099
(Assignee)

Updated

6 years ago
No longer blocks: 595020
Attachment #526749 - Flags: review?(sdwilsh)
Comment on attachment 526749 [details] [diff] [review]
patch v3

Review of attachment 526749 [details] [diff] [review]:
-----------------------------------------------------------------

r=sdwilsh

::: browser/base/content/test/tabview/browser_tabview_bug624727.js
@@ +63,5 @@
>      let prefix = 'enter';
>      ok(!pb.privateBrowsingEnabled, prefix + ': private browsing is disabled');
> +    registerCleanupFunction(function () {
> +      if (pb.privateBrowsingEnabled)
> +        pb.privateBrowsingEnabled = false

Why do you need the condition here?
Attachment #526749 - Flags: review?(sdwilsh) → review+
(Assignee)

Comment 9

6 years ago
(In reply to comment #8)
> ::: browser/base/content/test/tabview/browser_tabview_bug624727.js
> @@ +63,5 @@
> >      let prefix = 'enter';
> >      ok(!pb.privateBrowsingEnabled, prefix + ': private browsing is disabled');
> > +    registerCleanupFunction(function () {
> > +      if (pb.privateBrowsingEnabled)
> > +        pb.privateBrowsingEnabled = false
> 
> Why do you need the condition here?

That's just because of bug 651643. Seems we'll not get it before this one because I still experience some strange try failures there.
(Assignee)

Comment 10

6 years ago
Created attachment 533802 [details] [diff] [review]
patch for checkin
Attachment #526749 - Attachment is obsolete: true
Attachment #526749 - Flags: review?(paul)
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/24438e77a538
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.