650642 - [Pinstripe] Make the filterdialog and the advanced search dialogs look better

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Stefan [:stefanh]]

Attachment: Tweak search/filter dialogs

This is basically a port of the work I've done for seamonkey (clarkbw and I talked about this for a while ago). The most visible effect is the new buttons.

This also includes my proposal in bug 621546. It's all about these lines:
--------------------
+#searchTermList {
+  -moz-user-focus: ignore;
+}
+
+#searchTermList > listitem[selected="true"] {
+  background-color: inherit;
+}
--------------------

The last rule was in the original patch, that sort worsened the problem with no focus indication when you tabbed to the listbox. By adding the "ignore", the tab order is skipped for the listbox (see bug 621546 for more info). Another alternative is to remove the above rules.

Comment 1

[Stefan [:stefanh]]

Comment on attachment 526592 [details] [diff] [review]
Tweak search/filter dialogs

I noticed that I missed one listbox. I'll re-visit this when I'm back from holiday.

Comment 2

[Stefan [:stefanh]]

Attachment: In line with current SeaMonkey

OK, so we decided to put bug 621546 on hold - we should probably fix the xul instead. So, this patch is basically what's we have in SeaMonkey atm (with the problem of keyboard navigation).

Comment 3

[Stefan [:stefanh]]

Attachment: Screenshots with patch applied

Comment 4

[Andreas Nilsson (:andreasn)]

clarkbw: Do you want me to take this ui-review instead?

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 543687 [details] [diff] [review]
In line with current SeaMonkey

I'll pass this over to Andreas since I don't have a working build.

Comment 6

[Andreas Nilsson (:andreasn)]

Comment on attachment 543687 [details] [diff] [review]
In line with current SeaMonkey

Look good! I like this style!

Comment 7

[Stefan [:stefanh]]

Comment on attachment 543687 [details] [diff] [review]
In line with current SeaMonkey

Thanks Andreas. Giving the r? to Mark.

Comment 8

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 543687 [details] [diff] [review]
In line with current SeaMonkey

Review of attachment 543687 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Stefan,

I'm sorry it took me so long to get to this.  On the plus side, I'm happy with the code, so r=me.  :)

Thanks,
Blake.

Comment 9

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/90e169ce9243