Closed Bug 651486 Opened 9 years ago Closed 8 years ago

XML "Undefined entity" error page shown for entity "remoteXUL.title" in netError.xhtml

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(blocking-thunderbird5.0 beta1+)

RESOLVED FIXED
Thunderbird 5.0b1
Tracking Status
blocking-thunderbird5.0 --- beta1+

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: l12y)

Attachments

(1 file)

Attached patch The fixSplinter Review
+++ This bug was initially created as a clone of Bug #648268 +++

Our netError.xhtml display (e.g. if no network connection) is currently broken. Similar example of error on Fennec:

XML Parsing Error: undefined entity
Location: jar:file:///data/app/org.mozilla.fennec-1.apk!/chrome/toolkit/content/global/netError.xhtml
Line Number 331, Column 31:

<h1 id="et_remoteXUL">&remoteXUL.title</h1>
----------------------^


Attaching a patch that will fix this for Thunderbird.
Attachment #527255 - Flags: ui-review?(bwinton)
Attachment #527255 - Flags: review?(bwinton)
Comment on attachment 527255 [details] [diff] [review]
The fix

Review of attachment 527255 [details] [diff] [review]:

Is there any reason for us to not just steal the netError.dtd from mozilla/browser/locales/en-US/chrome/overrides ?

Here's the diff between your new one, and the browser one:
diff mail/locales/en-US/chrome/overrides/netError.dtd mozilla/browser/locales/en-US/chrome/overrides/netError.dtd
35a36
> 
55c56,61
< <!ENTITY netOffline.longDesc "
---
> <!-- LOCALIZATION NOTE (netOffline.overrideLongDesc) - This string should
>      indicate that "Work Offline" is a menu item without being too specific,
>      since it could be in either the normal menu (Mac/Linux) or the Firefox button
>      menu (Windows).
> -->
> <!ENTITY netOffline.overrideLongDesc "
57c63
<   <li>Place &brandShortName; in online mode, then try again.</li>
---
>   <li>Uncheck the &quot;Work Offline&quot; menu item, then try again.</li>
61c67
< <!ENTITY contentEncodingError.title "Content encoding error">
---
> <!ENTITY contentEncodingError.title "Content Encoding Error">
68c74
< <!ENTITY unsafeContentType.title "Unsafe file type">
---
> <!ENTITY unsafeContentType.title "Unsafe File Type">
124c130
< <!ENTITY nssFailure2.title "Secure connection failed">
---
> <!ENTITY nssFailure2.title "Secure Connection Failed">
128c134
<   <li>Please contact the website owners to inform them of this problem.</li>
---
>   <li>Please contact the web site owners to inform them of this problem. Alternatively, use the command found in the help menu to report this broken site.</li>
132c138
< <!ENTITY nssBadCert.title "Secure connection failed">
---
> <!ENTITY nssBadCert.title "Secure Connection Failed">
153c159
< <!ENTITY malwareBlocked.title "Suspected attack site!">
---
> <!ENTITY malwareBlocked.title "Suspected Attack Site!">
156c162
< <p>Website owners who believe their site has been reported as an attack site in error may <a href='http://www.stopbadware.org/home/reviewinfo'>request a review</a>.</p>
---
> <p>Web site owners who believe their site has been reported as an attack site in error may <a href='http://www.stopbadware.org/home/reviewinfo' >request a review</a>.</p>
159c165
< <!ENTITY phishingBlocked.title "Suspected web forgery!">
---
> <!ENTITY phishingBlocked.title "Suspected Web Forgery!">
175c181
< functionality specific to thunderbird. -->
---
> functionality specific to firefox. -->


The main thing that I think we might want to pick up is netOffline.longDesc -> netOffline.overrideLongDesc, but the others seem reasonable, too.

Either way, this is an improvement, so r=me, and ui-r=me, not necessarily in that order.  :)

Later,
Blake.
Attachment #527255 - Flags: ui-review?(bwinton)
Attachment #527255 - Flags: ui-review+
Attachment #527255 - Flags: review?(bwinton)
Attachment #527255 - Flags: review+
Alternatively you could consider overriding netErrorApp.dtd instead which allows you to pick and choose which strings to override (as long as you include the securityOverride strings) and won't break when new strings are added.
Checked in: http://hg.mozilla.org/comm-central/rev/05acd6314037
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
Filed bug 653386 on overriding netErrorApp.dtd rather than netError.dtd
Blocks: 663608
No longer blocks: 663608
You need to log in before you can comment on or make changes to this bug.