Closed
Bug 651622
Opened 13 years ago
Closed 13 years ago
Remove WinCE code from browser/*
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 6
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
47.32 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
WinCE code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. This bug is for the browser/* parts of the removal.
Assignee | ||
Comment 1•13 years ago
|
||
Removes all WinCE ifdef and ifeq related code from browser/* Benjamin, wasn't sure who to ask for review; your r= appeared on a few of the involved file's hg logs, however please let me know if someone else is actually more appropriate - thanks!
Comment 2•13 years ago
|
||
Comment on attachment 527386 [details] [diff] [review] Remove WinCE code from browser/* (*yoink*ing review) Out, damn'd spot! out, I say! I think this also makes the MOZ_FASTSTART stuff unused; WinCE and WinMobile were the only consumers afaik. Might double check with the mobile folks. In any case, let's do that as a separate bug.
Attachment #527386 -
Flags: review?(benjamin) → review+
Comment 3•13 years ago
|
||
> I think this also makes the MOZ_FASTSTART stuff unused; WinCE and WinMobile > were the only consumers afaik. Might double check with the mobile folks. In any > case, let's do that as a separate bug. There's also bug 503483 on enabling this for desktop but from the discussion in the bug I think its a WONTFIX.
Assignee | ||
Comment 4•13 years ago
|
||
Awesome, thanks for the fast review! Yeah MOZ_FASTSTART (and also I believe the ActiveX stuff) will be unused once the toolkit cleanup is done; I've made a note to deal with it then :-) Thanks for the link Matheus, hadn't seen that. I suspect as you say that the bug is WONTFIX - not just for the reasons inside, but also due to being made redundant by bug 627591 (windows) and bug 632404 (linux).
Keywords: checkin-needed
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/157b8fe56dd6 Thanks!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
Assignee | ||
Comment 6•13 years ago
|
||
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=^/browser/ ...returns 0 results. -> Verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•