652545 - Connect to Sync dialog shows non-functional ok/cancel buttons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Aakash Desai [:aakashd]]

Attachment: bug screenshot

Build id:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:6.0a1) Gecko/20110425 Firefox/6.0a1 Fennec/6.0a1 ID:20110425052833

Note: You need to be disconnected from sync

Steps to Reproduce:
1. Go to the preferences pane
2. Under "Sync", click on the "Connect" button.

Actual Results:
There are non-functional ok/cancel buttons at the bottom of the dialog.

Expected Results:
The ok/cancel buttons don't show up on the dialog.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

This was my fault for the change in Bug 652157. These dialogs are currently picking up a toolkit binding.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch v1

And this is the correct patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 528674 [details] [diff] [review]
Patch v1


>+dialog.content-dialog {
>+  -moz-binding: none;
>+}

add a comment above this to let us know we want to kill the default binding as well

Comment 5

[Wesley Johnston (:wesj)]

pushed: http://hg.mozilla.org/mozilla-central/rev/58abb421e04f

Comment 6

[Anna (Waverley)]

VERIFIED FIXED on: 
Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110429 Firefox/6.0a1 Fennec /6.0a1 

Device: HTC Desire Z (Android 2.2)