652942 - Re-enable test_hide_phishing_bar_from_message after test was disabled due to random orange

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

This seems to have been very frequent since bug 584339 landed:

mozmill.setTest :: {'name': 'test_hide_phishing_bar_from_message', 'filename': '/builds/slave/comm-aurora-macosx-opt-unittest-mozmill/build/mozmill/message-header/test-phishing-bar.js'}
error: uncaptured python exception, closing channel <jsbridge.network.BackChannel connected 127.0.0.1:24242 at 0x7b8fa8> (<type 'exceptions.KeyError'>:'message' [/tools/python/lib/python2.5/asyncore.py|readwrite|93] [/tools/python/lib/python2.5/asyncore.py|handle_read_event|390] [/tools/python/lib/python2.5/site-packages/jsbridge-2.3.7b1-py2.5.egg/jsbridge/network.py|handle_read|93] [/tools/python/lib/python2.5/site-packages/jsbridge-2.3.7b1-py2.5.egg/jsbridge/network.py|process_read|254] [/tools/python/lib/python2.5/site-packages/jsbridge-2.3.7b1-py2.5.egg/jsbridge/network.py|fire_callbacks|269] [/tools/python/lib/python2.5/site-packages/jsbridge-2.3.7b1-py2.5.egg/jsbridge/network.py|fire_event|290] [/tools/python/lib/python2.5/site-packages/mozmill-1.4.2b1-py2.5.egg/mozmill/__init__.py|__call__|104] [runtest.py|logFailure|362])
endRunner was never called. There must have been a failure in the framework.

My current thoughts are that there's no planning for the message display completion, and the assert_true isn't what we normally use in our tests.

I'm trying locally now to see if I can reproduce.

Comment 1

[Mark Banner (:standard8)]

I could easily reproduce locally on a debug build.

Unfortunately I couldn't work out what was actually causing the issue, therefore I've disabled the test for now as it is so frequent.

I think the issue is in or around help_test_hide_phishing_bar - mozmill just seems to get very upset at something in or around that function.

Comment 2

[Mark Banner (:standard8)]

ftr http://hg.mozilla.org/comm-central/rev/0a5aa0741361