653031 - Remove unused nsIPlatformCharset options

Status: RESOLVED DUPLICATE of bug 943272

(Core :: Internationalization, defect)

Description

[Makoto Kato [:m_kato]]

The following options in nsIPlatformCharset is unused.  We should remove it.

http://mxr.mozilla.org/mozilla-central/source/intl/locale/public/nsIPlatformCharset.h?mark=58-67#58

61      kPlatformCharsetSel_Menu = 2,
62      kPlatformCharsetSel_4xBookmarkFile = 3,
63      kPlatformCharsetSel_KeyboardInput = 4,
64      kPlatformCharsetSel_WindowManager = 5,
65      kPlatformCharsetSel_4xPrefsJS = 6,

Comment 1

[Ed Morley [:emorley]]

(In reply to comment #0)
> 61      kPlatformCharsetSel_Menu = 2,
http://mxr.mozilla.org/mozilla-central/search?string=kPlatformCharsetSel_Menu

Used here: 
http://mxr.mozilla.org/mozilla-central/source/intl/uconv/tests/nsTestUConv.cpp#1069

> 62      kPlatformCharsetSel_4xBookmarkFile = 3,
http://mxr.mozilla.org/mozilla-central/search?string=kPlatformCharsetSel_4xBookmarkFile

Used here: 
http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/os2/nsOS2Charset.cpp#95

> 63      kPlatformCharsetSel_KeyboardInput = 4,
Unused:
http://mxr.mozilla.org/mozilla-central/search?string=kPlatformCharsetSel_KeyboardInput

> 64      kPlatformCharsetSel_WindowManager = 5,
Unused:
http://mxr.mozilla.org/mozilla-central/search?string=kPlatformCharsetSel_WindowManager

> 65      kPlatformCharsetSel_4xPrefsJS = 6,
http://mxr.mozilla.org/mozilla-central/search?string=kPlatformCharsetSel_4xPrefsJS

Used here:
http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/os2/nsOS2Charset.cpp#95

For the ones that are still used, are they redundant / can they just be removed anyway?

Comment 2

[Makoto Kato [:m_kato]]

(In reply to comment #1)
> (In reply to comment #0)
> > 61      kPlatformCharsetSel_Menu = 2,
> http://mxr.mozilla.org/mozilla-central/search?string=kPlatformCharsetSel_Menu
> 
> Used here: 
> http://mxr.mozilla.org/mozilla-central/source/intl/uconv/tests/nsTestUConv.
> cpp#1069
> 
> > 62      kPlatformCharsetSel_4xBookmarkFile = 3,
> http://mxr.mozilla.org/mozilla-central/
> search?string=kPlatformCharsetSel_4xBookmarkFile
> 
> Used here: 
> http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/os2/
> nsOS2Charset.cpp#95
> 
> > 63      kPlatformCharsetSel_KeyboardInput = 4,
> Unused:
> http://mxr.mozilla.org/mozilla-central/
> search?string=kPlatformCharsetSel_KeyboardInput
> 
> > 64      kPlatformCharsetSel_WindowManager = 5,
> Unused:
> http://mxr.mozilla.org/mozilla-central/
> search?string=kPlatformCharsetSel_WindowManager
> 
> > 65      kPlatformCharsetSel_4xPrefsJS = 6,
> http://mxr.mozilla.org/mozilla-central/
> search?string=kPlatformCharsetSel_4xPrefsJS
> 
> Used here:
> http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/os2/
> nsOS2Charset.cpp#95
> 
> For the ones that are still used, are they redundant / can they just be
> removed anyway?

I will remove all enum.  No one uses 2nd parameter.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

You should remove kPlatformCharsetSel_PlainTextInFile too. It's been never available by bug 564774 fix.