The default bug view has changed. See this FAQ.

remove redundant storing of OpenType table copies, now that OTS doesn't discard them

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 528577 [details] [diff] [review]
patch, remove code to save copies of layout tables prior to OTS sanitization

Since bug 643460 landed, we no longer need to cache the OpenType tables from downloaded fonts, bypassing the sanitizer; the tables will remain in the main sfnt structure (unless they're invalid). So we can trim out the code that was responsible for squirrelling away a copy of the tables prior to sanitization.
Attachment #528577 - Flags: review?(jdaggett)
(Assignee)

Comment 1

6 years ago
Created attachment 528794 [details] [diff] [review]
patch, remove code to save copies of layout tables prior to OTS sanitization - merged to tip

Updated patch to current m-c tip.
Attachment #528577 - Attachment is obsolete: true
Attachment #528577 - Flags: review?(jdaggett)
Attachment #528794 - Flags: review?(jdaggett)

Comment 2

6 years ago
Comment on attachment 528794 [details] [diff] [review]
patch, remove code to save copies of layout tables prior to OTS sanitization - merged to tip

Excellent!!
Attachment #528794 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/52b6489a3140
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Depends on: 653408
(Assignee)

Comment 4

6 years ago
Backed out:
  http://hg.mozilla.org/mozilla-central/rev/7253ba2c9d6b
because it turned reftests orange due to bug 653408.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

6 years ago
Re-landed, hoping it sticks this time:
http://hg.mozilla.org/mozilla-central/rev/b7d79acc2930
(Assignee)

Updated

6 years ago
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.