Fade out URL bar text overflow in unfocused state

VERIFIED FIXED in Firefox 55

Status

()

defect
P1
normal
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: fryn, Assigned: dao)

Tracking

(Depends on 1 bug, Blocks 1 bug)

Trunk
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [photon-visual][p2])

Attachments

(1 attachment, 1 obsolete attachment)

URL Bar text overflow should smoothly fade out when unfocused.

I've made a proof-of-concept patch for this that works perfectly when the URL bar text field background is white, but it doesn't work for other backgrounds, e.g. high-contrast mode.

The most robust method of doing this is to apply an SVG mask to the URL bar text field. I'll investigate doing this later.

Another approach would be to implement CSS text-overflow: ellipsis and use that. :P
See Also: → 658467
Summary: URL Bar text overflow should smoothly fade out when unfocused → Fade out URL bar text overflow in unfocused state
(In reply to Frank Yan (:fryn) from comment #1)
> Created attachment 529055 [details] [diff] [review]
> proof-of-concept patch using transparent-to-white gradient
> 
> URL Bar text overflow should smoothly fade out when unfocused.
> 
> I've made a proof-of-concept patch for this that works perfectly when the
> URL bar text field background is white, but it doesn't work for other
> backgrounds, e.g. high-contrast mode.
> 
> The most robust method of doing this is to apply an SVG mask to the URL bar
> text field. I'll investigate doing this later.
> 
> Another approach would be to implement CSS text-overflow: ellipsis and use
> that. :P

We do now have text-overflow: ellipsis, so we could use it if we wanted. However, because the background-color here is opaque rather than an image, wouldn't we be able to use the system textbox background color rather than hardcoding #fff? That should work with high contrast themes, I believe...
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Assignee: nobody → dao+bmo
Status: RESOLVED → REOPENED
No longer depends on: 759568
Resolution: WONTFIX → ---
Attachment #529055 - Attachment is obsolete: true
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [photon-visual][p2]
Status: REOPENED → ASSIGNED
Iteration: --- → 55.5 - May 15
Flags: qe-verify- → qe-verify+
Comment on attachment 8866384 [details]
Bug 653670 - Fade out URL bar text overflow in unfocused state.

https://reviewboard.mozilla.org/r/138008/#review141184
Attachment #8866384 - Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4bc0ff1648e
Fade out URL bar text overflow in unfocused state. r=jaws
QA Contact: brindusa.tot
https://hg.mozilla.org/mozilla-central/rev/b4bc0ff1648e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
See Also: → 1364387
See Also: → 1364395
Depends on: 1364387
See Also: 1364387
Depends on: 1364395
See Also: 1364395
Component: Theme → Location Bar
Depends on: 1366240
I tested this issue on Mac OS X 10.10, Ubuntu 16.04, Windows 10 x64 and Windows 8.1 x64 with FF Nightly(2017-06-08) and I can't see any differences, on all OSes the text overflow is smoothly fade out when unfocused.
Please tell me if I need to do more tests before I mark this as Verified - Fix. Thanks
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.