6544 - Cannot search on XML page

Status: VERIFIED FIXED

(Core :: XML, defect, P3)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

You cannot search on XML page because in
nsTextServicesDocument::GetBodyNode we are looking for an element called
"body", which is generally not present in an XML document.

I believe this could be fixed by changing the above method to retrieve the
body node for HTML documents ONLY, and in other cases get the root node. You
should be able to QI the mDOMDocument to see if it is nsIHTMLDocument. If
it was not, just return the document's root node.

Note that it would probably be a good idea to change the method's name as well,
because we would be getting other tags as well for XML docs.

Comment 1

[mjudge]

this seems like kins back yard so i will let him clean up the mess ;)  Boing!
its in your court now kin

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: FIX: body for nsIHTMLDocument, root node otherwise

Comment 3

[Christine Hoffman]

Changing qa contact to [e-mail] because the issue is 'Selection and
Search' - just on a different type of document.

Comment 4

[kinmoz]

I'll revisit this in milestone M8.

Comment 5

[leger]

Per a request from Selection and Search component eng (mjudge) and qa (elig),
moving all "Selection and Search" bugs to new "Selection" component.  Original
"Selection and Search" component will be retired.

Comment 6

[Eli Goldberg]

[Changing component to XML; Claudius, please reassign if you believe this
assignation to be erroneous. Thanks!]

Comment 7

[kinmoz]

Changing milestone to M9 since I don't have time to look at spellchecker
issues yet.

Comment 8

[kinmoz]

Moving all spellchecker/text services related bugs to M11 since I will still be
working on AutoComplete features through M10.

Comment 9

[kinmoz]

Moving some SpellChecker/TextServices feature requests and bugs, that can wait
till after beta 1, to milestone M14.

Comment 10

[kinmoz]

*** Bug 20622 has been marked as a duplicate of this bug. ***

Comment 11

[kinmoz]

*** Bug 18566 has been marked as a duplicate of this bug. ***

Comment 12

[kinmoz]

I checked in a fix for this:

    mozilla/editor/txtsvc/src/nsTextServicesDocument.cpp revision 1.23
    mozilla/editor/txtsvc/src/nsTextServicesDocument.h revision 1.8

Fix should appear in the 01/27/2000 QA builds.

Comment 13

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I also reviewed the code, and tried searching on an XML page. Works, so marking 
verified.