654812 - "Remove All" should call nsILoginManager::removeAllLogins()

Status: NEW

(Thunderbird :: Preferences, defect)

Description

[Philipp von Weitershausen [:philikon]]

Right now the "Remove All" button handler loops over the logins and calls nsILoginManager::removeLogin() for each. I guess this is due to the fact that "Remove All" actually removes whatever the tree is showing, so if you're filtering logins by a search term, "Remove All" would only delete those. (I find that rather surprising, I would've expected that at least the button label changed to "Remove Shown" or something. But that's for a follow-up bug.)

It would be good if the "Remove All" button would call nsILoginManager::removeAll() when you're actually wiping all logins. Because that would send out the "removeAllLogins" notification which we'd like to listen to for bug 650201, to make Sharing accounts similar to stored passwords in terms of privacy.

Comment 1

[Philipp von Weitershausen [:philikon]]

(In reply to comment #0)
> It would be good if the "Remove All" button would call
> nsILoginManager::removeAll()

removeAllLogins()

Comment 2

[:Margaret Leibovic]

I started looking into this, and unless we change the UX around only removing the filtered logins, the best we could do would be to call removeAllLogins() only if no filter is applied.

Comment 3

[Matthew N. [:MattN]]

Yeah, I agree that's best we can do.