655361 - Move the browser too during firstrun sidebar discovery animation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Bug 625229 added a firstrun animation to show the sidebars.  However, the sidebars appear over the content area during this animation, instead of panning with the content area.  This is different from normal operation, and might be confusing.

This patch makes the content and sidebars animate together.  Tested on Galaxy Tab, and it is about as smooth with this patch as without.

If there's a better way of getting it to translate everything by the correct distance, I'd love to hear it. :)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's get UX to figure out if we care about the "float over" effect

Comment 2

[Aaron Train [:aaronmt]]

Attachment: Screenshot

Adding a screenshot of what I see, tracking to see if the attached patch will resolve that too.

Comment 3

[Brian Dils [:briandils]]

I think we should land this bug...its too weird to show a state that doesn't happen in the normal usage of the UI

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> I think we should land this bug...its too weird to show a state that doesn't
> happen in the normal usage of the UI

sounds good

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 530725 [details] [diff] [review]
patch

I really dislike the 121px we are using in CSS (not just here). I wonder if we should at least use a @variable@ for it

Comment 6

[Wesley Johnston (:wesj)]

Maybe we should just move this to javascript, where we can be sure we'll have the widths "semi" correct.

Also can't we just animate the entire #controls-scrollbox rather than moving three different boxes?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)
> Maybe we should just move this to javascript, where we can be sure we'll
> have the widths "semi" correct.

New bug

> Also can't we just animate the entire #controls-scrollbox rather than moving
> three different boxes?

Hmm, this has potential

Comment 8

[Matt Brubeck (:mbrubeck)]

(In reply to comment #6)
> Also can't we just animate the entire #controls-scrollbox rather than moving
> three different boxes?

Unfortunately, no.  #controls-scrollbox is only as wide as the screen; the sidebars are hidden in its overflow normally.

Comment 9

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/1f40aba2f1ac

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Android; Linux armv71; rv6.0a1) Gecko/20110513 Firefox/6.0a1 Fennec/6.0a1
Device: Droid 2 
OS: Android 2.2