|
1.85 MB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
Bug 652445 removed the following from toolkit/toolkit-tiers.mk: @@ -90,20 +87,16 @@ ifndef MOZ_NATIVE_BZ2 -ifeq ($(OS_ARCH),WINCE) -tier_platform_dirs += modules/lib7z -endif (in https://bugzilla.mozilla.org/attachment.cgi?id=528592&action=diff#a/toolkit/toolkit-tiers.mk_sec2) This now makes modules/lib7z/ unused (as far as I can tell, but am running past try to be sure): http://mxr.mozilla.org/mozilla-central/search?string=7zstub http://mxr.mozilla.org/mozilla-central/search?string=7zLib -> 438 files can be hg rm'd :-D
|
(Assignee) | |
Comment 1•6 years ago
|
||
The first MXR link above should instead be: http://mxr.mozilla.org/mozilla-central/search?string=lib7z
|
|
(Assignee) | |
Comment 2•6 years ago
|
||
Created attachment 531520 [details] [diff] [review] Remove modules/lib7z/ -- Blassey, once lib7z is removed, do you know if /other-licenses/7zstub/src/ is still used? This MXR search implies not... http://mxr.mozilla.org/mozilla-central/search?string=7zstub Just wondered if I can take it out at the same time - thanks! :-)
|
|
(Assignee) | |
Comment 3•6 years ago
|
||
(In reply to comment #2) > Remove modules/lib7z/ http://dev.philringnalda.com/tbpl/?tree=Try&rev=e179a3319e5f
|
||
Comment 4•6 years ago
|
||
I don't think its used elsewhere, but I don't see any reason to remove it either
|
|
(Assignee) | |
Comment 5•6 years ago
|
||
If it's not used why does it need to be kept? Dead code is unnecessary clutter that only serves to make the tree appear even more complicated to newcomers & is another 440 files that have to be searched when greping the tree for something else. If it is ever wanted in the future, well that's the whole point of a VCS. That and I'm sure the 3rd party code is out of date by now and would need to be updated from upstream anyway - so there's no point keeping this old version around.
|
|
||
Updated•6 years ago
|
||
|
|
(Assignee) | |
Updated•6 years ago
|
||
|
||
Updated•6 years ago
|
||
|
|
(Assignee) | |
Comment 6•6 years ago
|
||
Created attachment 532721 [details] [diff] [review] Remove modules/lib7z/ Only change is updated commit message to include the r=bsmedberg. Carrying forwards r+. Ready for check in (passed try in comment 3).
|
|
(Assignee) | |
Updated•6 years ago
|
||
|
||
Updated•6 years ago
|
||
|
|
||
Comment 7•6 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/1d0a6f0b04cb
Description
•