Closed Bug 656187 Opened 9 years ago Closed 9 years ago

Remove modules/lib7z/ since it was only used for the WinCE installer

Categories

(Core :: General, defect)

All
Windows CE
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 652445 removed the following from toolkit/toolkit-tiers.mk:

@@ -90,20 +87,16 @@ ifndef MOZ_NATIVE_BZ2
-ifeq ($(OS_ARCH),WINCE)
-tier_platform_dirs += modules/lib7z
-endif
(in https://bugzilla.mozilla.org/attachment.cgi?id=528592&action=diff#a/toolkit/toolkit-tiers.mk_sec2)

This now makes modules/lib7z/ unused (as far as I can tell, but am running past try to be sure):
http://mxr.mozilla.org/mozilla-central/search?string=7zstub
http://mxr.mozilla.org/mozilla-central/search?string=7zLib

-> 438 files can be hg rm'd :-D
Depends on: 652445
The first MXR link above should instead be:
http://mxr.mozilla.org/mozilla-central/search?string=lib7z
Attached patch Remove modules/lib7z/ (obsolete) — Splinter Review
--

Blassey, once lib7z is removed, do you know if /other-licenses/7zstub/src/ is still used? This MXR search implies not...
http://mxr.mozilla.org/mozilla-central/search?string=7zstub

Just wondered if I can take it out at the same time - thanks! :-)
Attachment #531520 - Flags: review?(blassey.bugs)
I don't think its used elsewhere, but I don't see any reason to remove it either
If it's not used why does it need to be kept?

Dead code is unnecessary clutter that only serves to make the tree appear even more complicated to newcomers & is another 440 files that have to be searched when greping the tree for something else. 

If it is ever wanted in the future, well that's the whole point of a VCS. That and I'm sure the 3rd party code is out of date by now and would need to be updated from upstream anyway - so there's no point keeping this old version around.
Attachment #531520 - Flags: review?(blassey.bugs)
Attachment #531520 - Flags: review?(benjamin)
Attachment #531520 - Flags: review?(benjamin) → review+
Only change is updated commit message to include the r=bsmedberg.
Carrying forwards r+.

Ready for check in (passed try in comment 3).
Attachment #531520 - Attachment is obsolete: true
Attachment #532721 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/1d0a6f0b04cb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.