656187 - Remove modules/lib7z/ since it was only used for the WinCE installer

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Ed Morley [:emorley]]

Bug 652445 removed the following from toolkit/toolkit-tiers.mk:

@@ -90,20 +87,16 @@ ifndef MOZ_NATIVE_BZ2
-ifeq ($(OS_ARCH),WINCE)
-tier_platform_dirs += modules/lib7z
-endif
(in https://bugzilla.mozilla.org/attachment.cgi?id=528592&action=diff#a/toolkit/toolkit-tiers.mk_sec2)

This now makes modules/lib7z/ unused (as far as I can tell, but am running past try to be sure):
http://mxr.mozilla.org/mozilla-central/search?string=7zstub
http://mxr.mozilla.org/mozilla-central/search?string=7zLib

-> 438 files can be hg rm'd :-D

Comment 1

[Ed Morley [:emorley]]

The first MXR link above should instead be:
http://mxr.mozilla.org/mozilla-central/search?string=lib7z

Comment 2

[Ed Morley [:emorley]]

Attachment: Remove modules/lib7z/

--

Blassey, once lib7z is removed, do you know if /other-licenses/7zstub/src/ is still used? This MXR search implies not...
http://mxr.mozilla.org/mozilla-central/search?string=7zstub

Just wondered if I can take it out at the same time - thanks! :-)

Comment 3

[Ed Morley [:emorley]]

(In reply to comment #2)
> Remove modules/lib7z/

http://dev.philringnalda.com/tbpl/?tree=Try&rev=e179a3319e5f

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

I don't think its used elsewhere, but I don't see any reason to remove it either

Comment 5

[Ed Morley [:emorley]]

If it's not used why does it need to be kept?

Dead code is unnecessary clutter that only serves to make the tree appear even more complicated to newcomers & is another 440 files that have to be searched when greping the tree for something else. 

If it is ever wanted in the future, well that's the whole point of a VCS. That and I'm sure the 3rd party code is out of date by now and would need to be updated from upstream anyway - so there's no point keeping this old version around.

Comment 6

[Ed Morley [:emorley]]

Attachment: Remove modules/lib7z/

Only change is updated commit message to include the r=bsmedberg.
Carrying forwards r+.

Ready for check in (passed try in comment 3).

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/1d0a6f0b04cb