Closed Bug 652445 Opened 8 years ago Closed 8 years ago

Remove WinCE & Windows Mobile code from toolkit

Categories

(Toolkit :: General, defect)

All
Windows CE
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla6

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(2 files, 2 obsolete files)

WinCE & Windows Mobile code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. 

This bug is for the toolkit/* parts of the removal.
Attached patch Part A - File removal (obsolete) — Splinter Review
Hg rm the following:
toolkit/mozapps/installer/wince/*
toolkit/components/faststart/*
toolkit/xre/nsSplashScreenWin.cpp

Faststart:
- Only ever worked on WinCE
- Partially removed already in bug 651622
- The proposal to add support for it on desktop (bug 503483) is looking like WONTFIX
- Likely to be made redundant by bug 627591 (windows) and bug 632404 (linux) anyway
-> Removed (http://mxr.mozilla.org/mozilla-central/search?string=faststart)

nsSplashScreenWin.cpp:
Deleted since the only reference to it is removed in patch part B. 
http://mxr.mozilla.org/mozilla-central/search?string=nsSplashScreenWin.cpp

All platforms now use nsSplashScreenDummy.cpp, which does nothing but return null (Android has a splashscreen but it doesn't use nsSplashScreen). However, will save full removal of nsSplashScreen* and MOZ_SPLASHSCREEN for a follow-up, since it will touch several other parts of the codebase + I will need to confirm that a splashscreen is not going to be re-added again in the future (unlikely but still).
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attached patch Part B - Everything Else (obsolete) — Splinter Review
Removal of all other WinCE/Windows Mobile ifdefs, plus MOZ_FASTSTART & related code.

Also removed some additional CAB package related lines in toolkit/mozapps/installer/packager.mk, since $(MAKE_CAB) is no loner used in toolkit/locales/l10n.mk.

Only extra thing to follow up is the potential removal of modules/lib7z/* ; since I believe it is no longer used after the toolkit-tiers.mk changes in this patch. However, will file separately since it will affect several areas outside of toolkit.
Comment on attachment 528053 [details] [diff] [review]
Part A - File removal

Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=3602f8c494ab
Attachment #528053 - Flags: review?(dtownsend)
Comment on attachment 528054 [details] [diff] [review]
Part B - Everything Else

Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=3602f8c494ab
Attachment #528054 - Flags: review?(dtownsend)
Attachment #528053 - Flags: review?(dtownsend) → review+
Attachment #528054 - Flags: review?(dtownsend) → review+
Thanks Dave! :-)
Keywords: checkin-needed
Only change is updated commit message to include the r=dtownsend & mention faststart/nsSplashScreenWin.

Carrying forwards r+
Attachment #528053 - Attachment is obsolete: true
Attachment #528591 - Flags: review+
Only change is updated commit message to include the r=dtownsend & mention faststart/nsSplashScreenWin.

Carrying forwards r+
Attachment #528054 - Attachment is obsolete: true
Attachment #528592 - Flags: review+
Blocks: 653333
http://hg.mozilla.org/mozilla-central/rev/8f79e7fc13d6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/toolkit/
...returns 0 results other than Google Breakpad, which from upstream, so is why was not touched.

-> Verified.
Status: RESOLVED → VERIFIED
Blocks: 656187
You need to log in before you can comment on or make changes to this bug.