657800 - Add-ons with binary components do not fail the bulk validation check

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Currently, Add-ons with binary components do not fail the bulk validation check

file extensions to check: dll, dylib, so

Comment 1

[Wil Clouser [:clouserw]]

I think that's because it's a warning and not an error.  If that's the case, we should make this a compat error, but keep it as a warning for regular validation.  I think we already did that for another test.

Comment 2

[Matt Basta [:basta]]

I can make it an error in compatibility results, but it won't be a tier 5 test. It also won't have the associated for_appversions element in the output. Someone will need to make sure, then, that this won't be ignored by the logic that filters compatibility messages. I think I recall Kumar mentioning that he uses some list comprehension for this, and that would lead to a possible bug.

Comment 3

[Kumar McMillan [:kumar]]

Matt, that would work fine actually.  Just add compatibility_type=error similar to how the navigator_language test sets this.  After bug 657830 (oops!) then it will do what we want and address this bug here.

Comment 4

[Wil Clouser [:clouserw]]

Matt, is it clear how to fix this?

Comment 5

[Matt Basta [:basta]]

Yup, I just finished the patch (with tests):

https://github.com/mozilla/amo-validator/pull/35

Comment 6

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/2d5c73ecbcb77a11c02b29228e5efe6fb412747f

Comment 7

[Kumar McMillan [:kumar]]

Pushed to Zamboni in https://github.com/jbalogh/zamboni-lib/commit/1eeef59

Comment 8

[Kumar McMillan [:kumar]]

Note that a fix to AMO's UI (bug 657830) was required to show binary errors correctly