Should refer computed delta value at dispatching pixel scroll event

RESOLVED FIXED in mozilla6

Status

()

defect
RESOLVED FIXED
8 years ago
2 months ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla6
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Patch v1.0 (obsolete) — Splinter Review
If override mechanism of system settings for mouse wheel scroll is enabled (it's enabled on Windows in default settings), the delta value of a pixel scroll event for high resolution scrolling should be computed with the overridden delta value.

See https://wiki.mozilla.org/Gecko:Mouse_Wheel_Scrolling#Override_system_of_system_scroll_speed for the detail of the mechanism.

This patch sets computed delta value (i.e., overridden delta value) to the query event's reply. And nsWindow uses the computed delta when it computes delta value of a pixel scroll event.

This patch depends on the patch for bug 657634. It prevents high resolution scrolling when acceleration is enabled. The acceleration mechanism is stateful, therefore, the acceleration and high resolution scrolling cannot be enabled same time.
Attachment #533287 - Flags: review?(Olli.Pettay)
Posted patch Patch v1.1Splinter Review
I'm sorry for the mistake.

It's wrong to compute our delta value for test event. I must not use orienter without native delta value.
Attachment #533287 - Attachment is obsolete: true
Attachment #533287 - Flags: review?(Olli.Pettay)
Attachment #533523 - Flags: review?(Olli.Pettay)
Comment on attachment 533523 [details] [diff] [review]
Patch v1.1

Jimm should probably look at at least the windows/ part.
Attachment #533523 - Flags: review?(jmathies)
Attachment #533523 - Flags: review?(Olli.Pettay)
Attachment #533523 - Flags: review+
Comment on attachment 533523 [details] [diff] [review]
Patch v1.1

Review of attachment 533523 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/windows/nsWindow.cpp
@@ +6456,1 @@
>  

nit - can we rename that var to something similar to mComputedScrollAmount since that's the value we use. I'm not a fan of 'scrollAmountPer*WHEEL_DELTA*|.
Attachment #533523 - Flags: review?(jmathies) → review+
http://hg.mozilla.org/mozilla-central/rev/87ec2a46a38c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Component: Event Handling → User events and focus handling
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.