As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 658153 - At using high resolution scrolling, the mouse wheel transaction doesn't work fine
: At using high resolution scrolling, the mouse wheel transaction doesn't work ...
: regression
Product: Core
Classification: Components
Component: Event Handling (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla6
Assigned To: Masayuki Nakano [:masayuki]
: Andrew Overholt [:overholt]
Depends on: 657935
Blocks: 605648 658111
  Show dependency treegraph
Reported: 2011-05-18 20:52 PDT by Masayuki Nakano [:masayuki]
Modified: 2011-05-23 08:09 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1.0 (1.41 KB, patch)
2011-05-18 20:52 PDT, Masayuki Nakano [:masayuki]
bugs: review+
Details | Diff | Splinter Review

Description User image Masayuki Nakano [:masayuki] 2011-05-18 20:52:48 PDT
Created attachment 533525 [details] [diff] [review]
Patch v1.0

There are a couple of issues:

1. nsMouseWheelTransaction::OnEvent() doesn't handle NS_MOUSE_PIXEL_SCROLL as NS_MOUSE_SCROLL. Therefore, pixel scroll event doesn't cause to end transaction even if mouse cursor is moved. This isn't a problem for Windows high resolution scroll, but this is actually a bug.

2. nsMouseWheelTransaction::OnEvent() doesn't handle NS_QUERY_SCROLL_TARGET_INFO as its mouse scroll event. NS_QUERY_SCROLL_TARGET_INFO causes calling DoScrollText() for querying the information. At this time, DoScrollText() calls nsMouseWheelTransaction::UpdateTransaction() without the mouse move check in OnEvent(). Therefore, if high resolution scrolling is enabled, mouse move doesn't cause canceling the transaction. This is a regression of bug 605648.
Comment 1 User image Masayuki Nakano [:masayuki] 2011-05-21 17:42:24 PDT
The patch needs the change for bug 657935. I'll land the patch with it.
Comment 2 User image Masayuki Nakano [:masayuki] 2011-05-23 08:09:28 PDT

Note You need to log in before you can comment on or make changes to this bug.