At using high resolution scrolling, the mouse wheel transaction doesn't work fine

RESOLVED FIXED in mozilla6

Status

()

Core
Event Handling
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({regression})

Trunk
mozilla6
x86
Windows 7
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 533525 [details] [diff] [review]
Patch v1.0

There are a couple of issues:

1. nsMouseWheelTransaction::OnEvent() doesn't handle NS_MOUSE_PIXEL_SCROLL as NS_MOUSE_SCROLL. Therefore, pixel scroll event doesn't cause to end transaction even if mouse cursor is moved. This isn't a problem for Windows high resolution scroll, but this is actually a bug.

2. nsMouseWheelTransaction::OnEvent() doesn't handle NS_QUERY_SCROLL_TARGET_INFO as its mouse scroll event. NS_QUERY_SCROLL_TARGET_INFO causes calling DoScrollText() for querying the information. At this time, DoScrollText() calls nsMouseWheelTransaction::UpdateTransaction() without the mouse move check in OnEvent(). Therefore, if high resolution scrolling is enabled, mouse move doesn't cause canceling the transaction. This is a regression of bug 605648.
Attachment #533525 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Attachment #533525 - Flags: review?(Olli.Pettay) → review+
The patch needs the change for bug 657935. I'll land the patch with it.
Depends on: 657935
http://hg.mozilla.org/mozilla-central/rev/2b79cd3ba840
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.