65871 - Page Setup should be added to the File menu

Status: VERIFIED WORKSFORME

(SeaMonkey :: MailNews: Message Display, enhancement, P2)

Description

[Ninoschka Baca]

Build 2001-01-17-08: NT4

Overview: The spec states that the File menu should have a "Page Setup" menu
item which doesn't exist right now. 

- "Page Setup" should appear first in the print section
- Mnemonic: "u" in Setup should be underlined
- Accelerator: "Ctrl+Shift+P" 

Is this a priority for the next release?

Comment 1

[Ninoschka Baca]

Marking nsbeta1 so it's determined whether this is a priority for this release.

Comment 2

[scottputterman]

marking nsbeta1-

Comment 3

[Stephen Walker]

Attachment: patch

Comment 4

[Stephen Walker]

Adding patch & review keywords. CC'ing myself.

Comment 5

[Håkan Waara]

Looks great! r=hwaara

Comment 6

[(not reading, please use [e-mail] instead)]

sorry for the delay, the patch looks good.

my only question is does "Page Setup" work?

if it doesn't do anything, we shouldn't add this to the UI.

sorry for asking a simple question like that, but I don't have trunk build to
test the patch on.

Comment 7

[Stephen Walker]

After talking this over with pchen, this bug shouldn't be fixed until the page 
setup dialog is actually implemented.

Comment 8

[Ninoschka Baca]

I cannot find a bug tracking the Page Setup dialog, does one exist?

Comment 9

[Stephen Walker]

nbaca: 42817 deals with the front-end work needed for page setup & 36796 deals 
with the back-end work needed for page setup. I marked this bug as depending on 
42817 in my last comment.

Comment 10

[Håkan Waara]

so, maybe someone should mark this bug LATER or WONTFIX ?

Comment 11

[Ninoschka Baca]

I think it should stay "New". Once bug# 42817 is fixed then this bug can be 
marked fixed and then verified.

Comment 12

[Ninoschka Baca]

It appears that it also depends on bug# 36796 for Mac specific issues.

Comment 13

[Kevin McCluskey (gone)]

bug 36796 has been closed. It covers the backend work to bring up the Mac Native
PageSetup dialog. 

We should add the PageSetup menu item for Mac and bring up the Native Mac Dialog
(This would allow Mac user's to specify landscape/portrait for the printer
output, etc.)

Comment 14

[Kevin McCluskey (gone)]

*** Bug 76378 has been marked as a duplicate of this bug. ***

Comment 15

[Steve Dagley]

This appears to be the magic bug that has to be fixed for Mac users to have 
access to Page Setup.  Raising the Pririty and Severity and bestowing the 
nsenterprise+ keyword.  Somebody please show me that this bug is now going to get 
somw lovin' since it appears to have been waiting for 36796 to be addressed (and 
being marked as a PC bug didn't exacly make it obvious it was one of the most 
annoying Mac bugs we've got)

Comment 16

[grega]

if this is to make emojo we need to get someone working on it immediately. 
Tiantian to follow up.

Comment 17

[Paul Chen]

taking this bug for now since we'd like to have this for next release, removing
minus from nsbeta1-, targetting mozilla0.9.5

Comment 18

[Paul Chen]

umm, no, really taking this bug...

Comment 19

[Jussi-Pekka Mantere]

Triaging nsenterprise-; not making the milestone at this time.

Peter, any other folks available who'd be able to work on this?

Comment 20

[Peter Trudelle]

Why?  I agree that it is too late to be adding new features to the branch.  Paul
can take it for 0.9.6

Comment 21

[Paul Chen]

Comment on attachment 27409 [details] [diff] [review]
patch

r=pchen

Comment 22

[Blake Ross]

Page Setup works on Mac?  We shouldn't be exposing this UI on Windows if it
doesn't work.

Comment 23

[Peter Trudelle]

Moving to mozilla0.9.7, need time to figure out cross platform issues. Also
marking as blocking 75643

Comment 24

[Peter Trudelle]

Whoops, wrong blocking bug, changing 75643 to 102472

Comment 25

[Paul Chen]

Simon Fraser snuck this in for 6.2, and it's on the trunk (mac only). Marking w4m

Comment 26

[Olga]

Verified on Win, Linux, Mac - recent trunk builds.