layout/xul/base/test/test_resizer.xul needs to move to mochitest-chrome, but fails on osx and winxp

RESOLVED FIXED in mozilla10

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jmaher, Assigned: Neil Deakin (mostly unavailable until September))

Tracking

(Blocks: 1 bug)

Other Branch
mozilla10
x86
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [specialpowers])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 534782 [details] [diff] [review]
patch to move test_resizer.xul to mochitest-chrome

in working on moving the .xul files from mochitest-plain to mochitest-chrome, I found that test_resizer.xul works great on linux and windows7, but fails on winxp and osx* with 108 failures.

Some logs from a try server run:
http://people.mozilla.org/~jmaher/specialpowers/

Here is an example of some of the failures:
7575 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenX - got 195, expected 200
7576 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenY - got 195, expected 200
7577 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerWidth - got 305, expected 300
7578 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerHeight - got 305, expected 300
7579 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenX - got 195, expected 200
7581 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerWidth - got 305, expected 300
7583 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenX - got 195, expected 200
7584 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenY - got 205, expected 200
7585 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerWidth - got 305, expected 300
7586 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerHeight - got 295, expected 300
7588 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenY - got 195, expected 200
7590 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerHeight - got 305, expected 300
7596 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenY - got 205, expected 200


If this shouldn't be moved to mochitest-chrome, let it be known.  Otherwise, some tips on what we need to change in order to get this running green.
(Reporter)

Updated

6 years ago
Blocks: 462483
Whiteboard: [specialpowers]
This test opens the test window (window_resizer.xul) twice, once as a top-level chrome window and one as a non-chrome document window. This test ensures that a non-privileged window cannot contain a resizer to resize the window. But because the test is running as a chrome url, it always succeeds.
Is this part of the test even relevant anymore now that we prohibit loading XUL from content pages?
(Reporter)

Comment 3

6 years ago
should we revisit this testcase?  should this run as a mochitest-chrome test?
Target Milestone: --- → mozilla7
Version: Trunk → Other Branch
Resizers can appear in unprivileged pages via the resize property, so a test to ensure one doesn't resize the window seems useful.
(Reporter)

Comment 5

6 years ago
so should we move this to mochitest-chrome and then create a mochitest-plain test case?
Depends on: 683394
Created attachment 557050 [details] [diff] [review]
updated patch

As part of this patch, I split the content portion into a separate test, which uncovered bug 683394 which this new tests now correctly checks.
Assignee: nobody → enndeakin
Attachment #534782 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Blocks: 680431
https://hg.mozilla.org/mozilla-central/rev/77b3b2868269
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: mozilla7 → mozilla10
Flags: in-testsuite+
Duplicate of this bug: 686016
You need to log in before you can comment on or make changes to this bug.