659338 - layout/xul/base/test/test_resizer.xul needs to move to mochitest-chrome, but fails on osx and winxp

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: patch to move test_resizer.xul to mochitest-chrome

in working on moving the .xul files from mochitest-plain to mochitest-chrome, I found that test_resizer.xul works great on linux and windows7, but fails on winxp and osx* with 108 failures.

Some logs from a try server run:
http://people.mozilla.org/~jmaher/specialpowers/

Here is an example of some of the failures:
7575 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenX - got 195, expected 200
7576 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenY - got 195, expected 200
7577 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerWidth - got 305, expected 300
7578 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerHeight - got 305, expected 300
7579 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenX - got 195, expected 200
7581 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerWidth - got 305, expected 300
7583 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenX - got 195, expected 200
7584 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenY - got 205, expected 200
7585 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerWidth - got 305, expected 300
7586 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerHeight - got 295, expected 300
7588 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenY - got 195, expected 200
7590 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window outerHeight - got 305, expected 300
7596 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/layout/xul/base/test/test_resizer.xul | window not moved for non-chrome window screenY - got 205, expected 200


If this shouldn't be moved to mochitest-chrome, let it be known.  Otherwise, some tips on what we need to change in order to get this running green.

Comment 1

[Neil Deakin]

This test opens the test window (window_resizer.xul) twice, once as a top-level chrome window and one as a non-chrome document window. This test ensures that a non-privileged window cannot contain a resizer to resize the window. But because the test is running as a chrome url, it always succeeds.

Comment 2

[(not currently active) Ted Mielczarek]

Is this part of the test even relevant anymore now that we prohibit loading XUL from content pages?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

should we revisit this testcase?  should this run as a mochitest-chrome test?

Comment 4

[Neil Deakin]

Resizers can appear in unprivileged pages via the resize property, so a test to ensure one doesn't resize the window seems useful.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

so should we move this to mochitest-chrome and then create a mochitest-plain test case?

Comment 6

[Neil Deakin]

Attachment: updated patch

As part of this patch, I split the content portion into a separate test, which uncovered bug 683394 which this new tests now correctly checks.

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/77b3b2868269