Can't use redo keyboard shortcut in Panorama

VERIFIED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: raymondlee, Assigned: raymondlee)

Tracking

Trunk
Firefox 7
x86
Linux

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
See bug 654601 comment 20
(Assignee)

Comment 1

6 years ago
Created attachment 535449 [details] [diff] [review]
v1
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #535449 - Flags: feedback?(tim.taubert)
Comment on attachment 535449 [details] [diff] [review]
v1

this patch contains no meaningful changes
Attachment #535449 - Flags: feedback?(tim.taubert) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 535475 [details] [diff] [review]
v1

Here is the complete patch
Attachment #535449 - Attachment is obsolete: true
Attachment #535475 - Flags: feedback?(tim.taubert)
(Assignee)

Updated

6 years ago
Attachment #535475 - Attachment is patch: true
Attachment #535475 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 535475 [details] [diff] [review]
v1

Review of attachment 535475 [details] [diff] [review]:
-----------------------------------------------------------------

To make redo work for mac and windows (with Ctrl+Y) we'd need to add a switch-case for that command in the if-branch without the shift key.
Attachment #535475 - Flags: feedback?(tim.taubert) → feedback-
(Assignee)

Comment 5

6 years ago
Created attachment 535641 [details] [diff] [review]
v2
Attachment #535475 - Attachment is obsolete: true
Attachment #535641 - Flags: feedback?(tim.taubert)
Comment on attachment 535641 [details] [diff] [review]
v2

Review of attachment 535641 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #535641 - Flags: feedback?(tim.taubert) → feedback+
(Assignee)

Updated

6 years ago
Attachment #535641 - Flags: review?(ian)
Comment on attachment 535641 [details] [diff] [review]
v2

Review of attachment 535641 [details] [diff] [review]:
-----------------------------------------------------------------

Cool.
Attachment #535641 - Flags: review?(ian) → review+
(Assignee)

Comment 8

6 years ago
Created attachment 536506 [details] [diff] [review]
Patch for checkin
Attachment #535641 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/fd0b5d64aac6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Version: unspecified → Trunk

Comment 10

6 years ago
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110609 Firefox/7.0a1

I just reproduced this problem on Ubuntu 11.04, Mac OS X 10.6 and WinXP.

Steps to reproduce:
 1. Go to Panorama
 2. Write anything in title bar of a group
 3. Delete a few characters
 4. Undo using CTRL+Z
 5. Press CTRL+Y to redo

Actual results:
 - nothing happens
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 11

6 years ago
(In reply to comment #10)
> Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110609 Firefox/7.0a1
> 
> I just reproduced this problem on Ubuntu 11.04, Mac OS X 10.6 and WinXP.
> 
> Steps to reproduce:
>  1. Go to Panorama
>  2. Write anything in title bar of a group
>  3. Delete a few characters
>  4. Undo using CTRL+Z
>  5. Press CTRL+Y to redo
> 
> Actual results:
>  - nothing happens

The redo key combination is ctrl/cmd+shift+z

http://support.mozilla.com/en-US/kb/Keyboard%20shortcuts#w_editing
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0

Verified fixed. This issue is no longer reproducible when using the following Steps to reproduce:

1. Go to Panorama
2. Write anything in title bar of a group
3. Delete a few characters
4. Undo using CTRL+Z
5. Press CTRL+Shift+Z to redo
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.