661239 - New mail notification shown for autosaved drafts

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jonathan Protzenko [:protz]]

Sometimes I receive the new mail notification for mails that have been autosaved in my Drafts folder (IMAP) because I have a compose window open and it auto-saves the draft. I don't think these should be shown.

Possible fix, but I don't know if we want to do that: don't show the new mail alert if the folder that contains the message has nsMsgFolderFlags::Drafts (or nsMsgFolderFlags::Junk as well).

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

This patch causes the new mail notification system to ignore folders with the following flags:  Drafts, Queue, SentMail, Templates and Junk.

I've added some regression tests, and all notification tests still pass.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I believe this will also fix bug 272125 for Linux.

Comment 3

[David :Bienvenu]

Comment on attachment 536693 [details] [diff] [review]
Patch v1

What if the Inbox has one of those flags set? I think you want to make sure that the folder is not the inbox as well.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2

Thanks for the review, Bienvenu!

We now only filter out the uninteresting folders if the Inbox flag is not set.  Regression test added, and all notification tests pass.

Comment 5

[David :Bienvenu]

Comment on attachment 536702 [details] [diff] [review]
Patch v2

I forgot that I can't really run this, not having linux installed. But it looks fine.

Comment 6

[Jonathan Protzenko [:protz]]

Mike, are you positive that your boolean expression is correct? I think you need parentheses there...

Comment 7

[Peter Lairo]

(In reply to comment #1)
> This patch causes the new mail notification system to ignore folders with
> the following flags:  Drafts, Queue, SentMail, Templates and Junk.

What about the Archive folder?

As suggested here: news://news.mozilla.com:119/[e-mail]

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v3

Protz:  thanks for the heads up - I've added the parentheses (I assume we were thinking of the same ones?)

Peter:  I've added the Archive folder flag to the list of folders that we don't notify.  Thanks!

Comment 9

[Jonathan Protzenko [:protz]]

Yes the parentheses are what I had in mind. Thanks!

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 537638 [details] [diff] [review]
Patch v3

Review of attachment 537638 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 11

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/30308622251c