661396 - Run contrib/reorg-tools/migrate_crash_signatures.pl script against live BMO database.

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[David Lawrence [:dkl]]

Attachment: Script to migrate crash signatures from summary to new signature field (v1)

The attached script will need to be ran against the production BMO database once the new cf_crash_signature textarea field has been created. The script will match crash bugs by using the following SQL:

    SELECT bugs.bug_id, bugs.short_desc
      FROM bugs LEFT JOIN keywords ON bugs.bug_id = keywords.bug_id
     WHERE (keywords.keywordid = ? OR keywords.keywordid = ?)
           AND bugs.status_whiteboard NOT REGEXP '\\[notacrash\\]'
           AND bugs.short_desc REGEXP '\\\\[@.+\\\\]'
           AND (bugs.cf_crash_signature IS NULL OR bugs.cf_crash_signature = '')
  ORDER BY bugs.bug_id

a) topcrash or crash keyword
b) status whiteboard does NOT contain [notacrash]
c) summary contains signature in the form of [@.+]
d) crash signature field is currently empty.

The script will pull out multiple signatures in the summary and add them to the new crash signature custom field each on a separate line.

Once the new field is created and the proper people sign off, we can schedule a time to run the migration script.

dkl

Comment 1

[:glob ✱]

Comment on attachment 536751 [details] [diff] [review]
Script to migrate crash signatures from summary to new signature field (v1)

Review of attachment 536751 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: contrib/reorg-tools/migrate_crash_signatures.pl
@@ +18,5 @@
> +#      COMPANY:  Mozilla Corproation
> +#      VERSION:  1.0
> +#      CREATED:  05/31/2011 03:57:52 PM
> +#     REVISION:  1
> +#===============================================================================

nit: probably should use the standard boiler plate, which includes the license.

Comment 2

[David Lawrence [:dkl]]

migration script has been ran on production. Please open a new bug if any issues are found.

dkl

Comment 3

[Robert Kaiser]

(In reply to comment #2)
> migration script has been ran on production. Please open a new bug if any
> issues are found.

Hmm, from a random sample out of bugs I recently got bugmail for, it looks to me like only few crash bugs did get this migrated.

Bugs that have it OK: bug 659924, bug 613954
Bugs that don't have it: bug 538724, bug 657292, bug 611023, bug 648022, bug 661873, bug 605033

An error in the query to find the bugs to work on?

Comment 4

[David Lawrence [:dkl]]

(In reply to comment #3)
> (In reply to comment #2)
> > migration script has been ran on production. Please open a new bug if any
> > issues are found.
> 
> Hmm, from a random sample out of bugs I recently got bugmail for, it looks
> to me like only few crash bugs did get this migrated.
> 
> Bugs that have it OK: bug 659924, bug 613954
> Bugs that don't have it: bug 538724, bug 657292, bug 611023, bug 648022, bug
> 661873, bug 605033
> 
> An error in the query to find the bugs to work on?

It would seems so. Seems that an error in the way the SQL handled the regex we used missed those and so they were untouched. We can definitely tweak the migration script to pull in those extras which should not affect the ones already migrated. Let me see what I can do.

dkl

Comment 5

[David Lawrence [:dkl]]

Found an error in the SQL that missed ~3000 bugs so I will see if I can get IT to run it once more.

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified contrib/reorg-tools/migrate_crash_signatures.pl
Committed revision 7762.

dkl

Comment 6

[Robert Kaiser]

Hmm, strange, it has been run again with the fix, if I interpret the messages correctly, but the bugs I mentioned in comment #3 still don't have the field filled out. :(

Comment 7

[David Lawrence [:dkl]]

(In reply to comment #6)
> Hmm, strange, it has been run again with the fix, if I interpret the
> messages correctly, but the bugs I mentioned in comment #3 still don't have
> the field filled out. :(

Sigh. My fault in that I forgot to tell the IT person to add the argument to the command line to actually make it do the database updates. Will try to get them to run it yet again today. Sorry for the delays.

dkl

Comment 8

[David Lawrence [:dkl]]

Ok, it has been ran again. It has fixed the bugs you mentioned with the exception of bug 657292. I will fix that one manually and try to see what caused that one. Let me know if you see others.

dkl

Comment 9

[Robert Kaiser]

Now those look good, thanks. I think it's time to mark this one fixed again. :)

Comment 10

[Robert Kaiser]

Oh, didn't spot the "fix that one manually". We'll keep our eyes open. Still, thanks a lot!

Comment 11

[Robert Kaiser]

(In reply to comment #8)
> Ok, it has been ran again. It has fixed the bugs you mentioned with the
> exception of bug 657292. I will fix that one manually and try to see what
> caused that one.

Just noted that this one was missing the "crash" keyword, so this was expected.

Comment 12

[David Lawrence [:dkl]]

Thanks