662015 - Dualbuttons in message header have no right margin

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Jim Porter (:squib)]

Attachment: Screenshot

As seen in the attached screenshot, the dualbuttons ("reply all" and "save") have no right margin, which looks strange. The "reply all" button also has a too-large left margin. This is a minor issue, but still kinda annoying, especially for the "save" button, which defaults to being the rightmost one.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Fix with Bug 618611

In Bug 618611 I solved this. Andreasn hasn't decided, if he wants this change. If not, I can use this Bug.

Comment 2

[Jim Porter (:squib)]

Attachment: A patch to fix this

Here's a patch that fixes this and makes dualbuttons use the same margins as everything else.

Comment 3

[Jim Porter (:squib)]

Oh, good to see that you already noticed this. :) I suppose either way is fine with me, though I think the spacing between buttons in your version matches Firefox, whereas mine doesn't. Still, if bug 618611 doesn't make it into Miramar, this might, since it's a smaller fix...

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 537320 [details] [diff] [review]
A patch to fix this

Review of attachment 537320 [details] [diff] [review]:
-----------------------------------------------------------------

Does this only happen under Aero?

If so, the change looks good to me, although I would prefer getting bug 618611 in instead…

Thanks,
Blake.

Comment 5

[Jim Porter (:squib)]

(In reply to comment #4)
> Does this only happen under Aero?

I guess it depends on what you mean by "Aero". It happens in the "Windows 7 Basic" theme, but not in the XP theme. At least I think it's ok for XP; everything worked as of a few weeks ago when I was on XP, but I've yet to set up an XP VM to test things out now that I'm on Windows 7.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to comment #4)
> Does this only happen under Aero?

Yes, XP is okay

> If so, the change looks good to me, although I would prefer getting bug
> 618611 in instead…

Andreasn has some problems with his Win machine for the review. If this lands I can update the patch for bug 618611.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Well, it's been a while.  I say we check this in, because it's been reviewed, and update the patch for bug 618611.

Thanks,
Blake.

Comment 8

[Jim Porter (:squib)]

Comment on attachment 537320 [details] [diff] [review]
A patch to fix this

Setting approval flags... I'm not sure if we want this for 5.0 (it's not *that* noticeable), but maybe 6.0?

Comment 9

[Jim Porter (:squib)]

Checked in on trunk: http://hg.mozilla.org/comm-central/rev/174e92903cc2

Comment 10

[Mark Banner (:standard8)]

Please remember to mark as fixed when something lands on trunk. Branches have their own flags.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 537320 [details] [diff] [review]
A patch to fix this

Too late for 5.0, but we'll take it for aurora/tb6.

Comment 12

[Jim Porter (:squib)]

Checked in on aurora: http://hg.mozilla.org/releases/comm-aurora/rev/f293f6c073c2