618611 - Investigate appearance of MsgHeader buttons on Linux and Windows

Status: RESOLVED WONTFIX

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The actual MsgHeader buttons are looking heavy comparing to the toolbar buttons. The -moz-appearance: button let show always the button body. With -moz-appearance: toolbarbutton the body is only shown on hover

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Default appearance of MsgHeader buttons

The MsgHeader buttons are the only buttons where the button body is viewable.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: MsgHeader buttons with -moz-appearance: toolbarbutton

All buttons have the same appearance

Comment 3

[Richard Marti (:Paenglab)]

Andreas and Bryan what do you mean about this?

Comment 4

[Richard Marti (:Paenglab)]

Now I have again access to Win XP. On this platform are the buttons in the header pane also with appearance button instead of toolbarbutton. For this I change to platform=All.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Use toolbarbutton instead of button

This patch changes the appearance from button to toolbarbutton. The 'other actions' button is now also a toolbarbutton instead of a special styled button.

I cleaned also no more needed or double applied definitions.

This all made the #expandedHeaderView under Linux and Win7 9px and under XP 12px less high.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 535943 [details] [diff] [review]
Use toolbarbutton instead of button

>+++ b/mail/themes/gnomestripe/mail/messageHeader.css
>@@ -249,47 +248,27 @@
>+/* Because toolkit's toolbarbutton.css don't know labelalign="end" and forces a

"doesn't know".

>+ * margin of 0, jamming the image up against the text, so we need this

You should remove the "so".

>+++ b/mail/themes/qute/mail/messageHeader.css
>@@ -278,47 +273,23 @@
>+/* Because toolkit's toolbarbutton.css don't know labelalign="end" and forces a
>+ * margin of 0, jamming the image up against the text, so we need this
>+ * !important rule to override that.

(Same as above.)

>-toolbox[labelalign="end"] toolbar[mode="full"] toolbarpaletteitem .msgHeaderView-button .toolbarbutton-text,
>+ 

There's a single trailing space on this line.  (It's the only one I could find.  :)


I'll let Andreas decide how he likes the look under Windows XP and Linux (and don't forget to customize the toolbar, and add a splitter to see how that looks, Andreas!) but the code itself looks pretty good to me.  r=me with the nits fixed.

Thanks,
Blake.

Comment 7

[Andreas Nilsson (:andreasn)]

I still haven't decided if I like this change or not. :)

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Use toolbarbutton instead of button

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 536380 [details] [diff] [review]
Use toolbarbutton instead of button

Pressed to early enter.

Updated patch addressing review comments.
Carrying r+ from previous patch

Comment 10

[Richard Marti (:Paenglab)]

Attachment: Updated patch

Updated patch after landing of bug 656045

Carrying over r+ from previous patch

Comment 11

[Richard Marti (:Paenglab)]

Attachment: MessageHeader patch

I removed two !important to much, so adding them again. This made toolbarbutton[type="menu"] shrinking 2px on hover under XP.

Comment 12

[Richard Marti (:Paenglab)]

Attachment: MessageHeader patch

Updated patch after landing of Bug 662015.

Carrying over r+

Comment 13

[Richard Marti (:Paenglab)]

This patch could also solve bug 525210 and bug 525628.

Andreas please can you decide if you like this change? Maybe only for Windows. The patch would be bitrotted and needs a update if still desired.

Comment 14

[Andreas Nilsson (:andreasn)]

Comment on attachment 541750 [details] [diff] [review]
MessageHeader patch

As agreed on IRC, setting this to minus.
Things looks messy in the message header without the buttons and I don't think a bit of inconsistency will harm us that much (the message header is not really a regular toolbar). I do think we can still do something to make them look lighter. Will make some mockups.

Comment 15

[Ludovic Hirlimann [:Usul]]

(In reply to Andreas Nilsson (:andreasn) from comment #14)
> Comment on attachment 541750 [details] [diff] [review] [diff] [details] [review]
> not really a regular toolbar). I do think we can still do something to make
> them look lighter. Will make some mockups.

Ping ?

Comment 16

[Wayne Mery (:wsmwk)]

josiahone, any thoughts?

Comment 17

[Josiah Bruner [:jsbruner]]

I think we could copy what we're doing on OS X right now. (Slight opacity until hovered)