663272 - NTT should support SeaMonkey nightlies the way ChatZilla, Venkman and DOM Inspector now do

Status: RESOLVED FIXED

(Other Applications Graveyard :: Nightly Tester Tools, defect)

Description

[Tony Mechelynck [:tonymec]]

Attachment: patch v0

Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110609 Firefox/7.0a1 SeaMonkey/2.4a1 ID:20110609003045

This user-agent is the current SeaMonkey trunk nightly.

IMHO, compatibility with trunk nightlies is the lifeblood of this extension. Now AFAICT it is already compatible at the code level, the only remaining problems are compatibility at the install.rdf level and min/max versions reported at AMO.

This bug is about install.rdf; the version listed at AMO can be handled in a followup bug or off-Bugzilla.

See for comparison how a similar problem was solved:
by bug 662615 for Venkman
by bug 662619 for DOM Inspector
by bug 662622 for ChatZilla

Ian, this is my first patch ever. The path is wrong and I don't know my way in the labyrinth of the Mozilla code tree. Could you please help me find the right path in the source?

Comment 1

[Tony Mechelynck [:tonymec]]

Attachment: patch v0.1

I've found the place: in the top-level directory of http://github.com/mozautomation/nightlytt

This is the same patch, corrected for bit-rot and using "gif diff" format.

Ian, I'm still asking your opinion from the SeaMonkey POV. If positive, I'll see about how to get it approved-or-whatever by the project owners.

Comment 2

[Ian Neal]

Comment on attachment 538401 [details] [diff] [review]
patch v0.1

It looks like the right sort of thing, but I can only give feedback, you would need review off :harth

Comment 3

[Heather Arthur [:harth]]

Comment on attachment 538401 [details] [diff] [review]
patch v0.1

this looks good, I'll check it in soon

Comment 4

[Heather Arthur [:harth]]

Should be fixed.

Comment 5

[Tony Mechelynck [:tonymec]]

Attachment: patch v1

(In reply to comment #4)
> Should be fixed.

Hm, I had cloned the git master (which gave me an extension version of 3.1.5) but apparently the version at AMO was already 3.1.7 (so existing installations of NTT won't auto-upgrade). Sorry.

This is an incremental diff against the current master.

Comment 6

[Tony Mechelynck [:tonymec]]

Comment on attachment 538401 [details] [diff] [review]
patch v0.1

oops, this one was checked in and should remain so; removing the obsolete flag.

Comment 7

[Heather Arthur [:harth]]

(In reply to comment #6)
> Comment on attachment 538401 [details] [diff] [review] [review]
> patch v0.1
> 
> oops, this one was checked in and should remain so; removing the obsolete
> flag.

Ah, I should have caught that and/or pushed the code on AMO to Github. I fixed this on GitHub and it'll be correct in the next release. Thanks!

For future reference, if you want you can just send a pull request for a faster turn around on these things. I also can then use your username for the commits.

Comment 8

[Tony Mechelynck [:tonymec]]

(In reply to comment #7)
[...]
> For future reference, if you want you can just send a pull request for a
> faster turn around on these things. I also can then use your username for
> the commits.

What is a "pull request"?

Comment 9

[Heather Arthur [:harth]]

A pull request is an easy way to get code into the upstream on GitHub http://help.github.com/send-pull-requests/

(In reply to comment #8)
> (In reply to comment #7)
> [...]
> > For future reference, if you want you can just send a pull request for a
> > faster turn around on these things. I also can then use your username for
> > the commits.
> 
> What is a "pull request"?

Comment 10

[Tony Mechelynck [:tonymec]]

(In reply to comment #9)
> A pull request is an easy way to get code into the upstream on GitHub
> http://help.github.com/send-pull-requests/

Hm, I see. Maybe I'm obtuse, or old-fashioned, but I don't feel the need for it. I have a git clone of your NTT repository, I can synchronize it at any time with your current master, and if ever I propose a patch I can attach a "git diff" to a bug, which you can then import at your leisure. I don't think it will be often. :-)

I suppose you may, if you want, mention my name and/or email address (as seen on top of this BMO comment) in the commit message, but I don't require it. What matters to me is having working software; whether or not it has my name on the label is secondary.

Comment 11

[Tony Mechelynck [:tonymec]]

Pushed 2011-06-11 as https://github.com/mozautomation/nightlytt/commit/7e13b60246dfaec28727044abde32384c2642d72

Comment 12

[Heather Arthur [:harth]]

Comment on attachment 538731 [details] [diff] [review]
patch v1

just r+ing, we'll do this on next release