Closed
Bug 663795
Opened 13 years ago
Closed 13 years ago
clean up browser_tabview_bug587990.js
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 7
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.18 KB,
patch
|
dietrich
:
review+
raymondlee
:
feedback+
|
Details | Diff | Splinter Review |
This test is unnecessarily complicated and should use the new head.js functions.
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Comment on attachment 538876 [details] [diff] [review]
patch v1
>+ waitForFocus(finish);
What's the point of using waitForFocus here?
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to comment #2)
> >+ waitForFocus(finish);
>
> What's the point of using waitForFocus here?
I wrote this patch before bug 663584 so I guess I can remove this - though I'm not sure because I really can't remember why and when I started doing this.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #538876 -
Attachment is obsolete: true
Attachment #538876 -
Flags: feedback?(raymond)
Attachment #538903 -
Flags: feedback?(raymond)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 538903 [details] [diff] [review]
patch v2
Looks good!
Attachment #538903 -
Flags: feedback?(raymond) → feedback+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #538903 -
Flags: review?(dietrich)
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 538903 [details] [diff] [review]
patch v2
Passed try:
http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=e8220cdda682
|
||
Comment 7•13 years ago
|
||
Comment on attachment 538903 [details] [diff] [review]
patch v2
Review of attachment 538903 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #538903 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 8•13 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 9•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•