clean up browser_tabview_bug587990.js

RESOLVED FIXED in Firefox 7

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 7
Bug Flags:
in-testsuite -

Details

Attachments

(1 attachment, 1 obsolete attachment)

This test is unnecessarily complicated and should use the new head.js functions.
Created attachment 538876 [details] [diff] [review]
patch v1
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Attachment #538876 - Flags: feedback?(raymond)
Comment on attachment 538876 [details] [diff] [review]
patch v1

>+    waitForFocus(finish);

What's the point of using waitForFocus here?
(In reply to comment #2)
> >+    waitForFocus(finish);
> 
> What's the point of using waitForFocus here?

I wrote this patch before bug 663584 so I guess I can remove this - though I'm not sure because I really can't remember why and when I started doing this.
Created attachment 538903 [details] [diff] [review]
patch v2
Attachment #538876 - Attachment is obsolete: true
Attachment #538876 - Flags: feedback?(raymond)
Attachment #538903 - Flags: feedback?(raymond)
Comment on attachment 538903 [details] [diff] [review]
patch v2

Looks good!
Attachment #538903 - Flags: feedback?(raymond) → feedback+
Attachment #538903 - Flags: review?(dietrich)
Comment on attachment 538903 [details] [diff] [review]
patch v2

Passed try:

http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=e8220cdda682
Comment on attachment 538903 [details] [diff] [review]
patch v2

Review of attachment 538903 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #538903 - Flags: review?(dietrich) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/1a1f55c9ad67
Whiteboard: [inbound]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/1a1f55c9ad67
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.