663919 - Search machine icon missing in address field

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Glutton.Vidal]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20110608 Firefox/4.0.1 SeaMonkey/2.1
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20110608 Firefox/4.0.1 SeaMonkey/2.1

In older versions (e.g. 2.0.14) You can see the icon of the search machine ...
honestly I was used to click on the right search button ... as this was removed I needed a long time till I realized it after using 2.0.14 since a long time again, that I have to click below the address field.
This would be clear obvious with the icon(as seen in the modified screen shot)
http://img829.imageshack.us/img829/9250/searchmachine.jpg



Reproducible: Always

Steps to Reproduce:
1. Give in a search word
2.Click below the address field
3.

Comment 1

[Philip Chee]

Image Shack says I need to register to see that pic, but I think I know what you mean.

Comment 2

[Glutton.Vidal]

Strange! I'm not registered there, and use it often for forums without access problems for others.

Comment 3

[Philip Chee]

I live in a country that Image Shack doesn't like.

Comment 4

[Philip Chee]

<RattyAway>
NeilAway: Bug 663919 is this intentional or an oversight on our part?
<NeilAway>
RattyAway: it's completely broken :-(
...

So can we fix it Bob?

Comment 5

[therube]

Attachment: Picture for Ratty (not on imageshack.us)

Comment 6

[[e-mail]]

Attachment: Proposed patch

addEngine used to take an icon string. The iconURI is an nsIURI, not a string, and it may be null, so I null-check it and use its spec if it exists.

Comment 7

[Ian Neal]

Comment on attachment 544976 [details] [diff] [review]
Proposed patch

r=me and a=me for any repos that need it.

Comment 8

[[e-mail]]

Pushed changeset 24b8803d73c0 to comm-central.

Transplant required for comm-aurora and comm-beta, so setting checkin-needed.

Comment 9

[Philip Chee]

Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/4f6302029117
http://hg.mozilla.org/releases/comm-beta/rev/402abcbf2da0