66454 - Mozilla crash when password manager opens

Status: VERIFIED DUPLICATE of bug 60280

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Landis Reed]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; 0.7) Gecko/20010109
BuildID:    2001010901

Mozilla will crash every time I say yes to password manager and 98% of the time
 on this site, when I say no to password manager. This site more than oters.
Answering No, on other sites useally gets me by.

Reproducible: Always
Steps to Reproduce:
Go to this site, enter user ID (my full name) and password. Click yes or no to
password manager. I've never tried "never on this site".					

Actual Results:  Mozilla produced a fault,, Crash. I don't have drwatson
producing a log, so I can't tell you exactly.

Expected Results:  Should log in.	

Windows NT 4, sp6a, 512MB RAM, PII 333, 2 - Millenium II 8MB Vedio adapters,
AHA-154X, 3Com 3C905-TX in 10MB consintrator on 100MB Network, attached to net
via T-1 (2 consentrators between this machine to DSU.).

Comment 1

[Stephen P. Morse]

*** Bug 66455 has been marked as a duplicate of this bug. ***

Comment 2

[Stephen P. Morse]

OK, I'm not seeing a crash but I am seeing something else very distressing.  
Namely when I respond to the password-manager dialog, there is another such 
dialog just below it waiting for me to respond to.  If you respond to these in 
the wrong order, I can well see how a crash could occur, although I myself did 
not observe a crash.

To demonstrate the double dialog, before clicking a button to close the dialog, 
move the dialog a little.  This will expose the second dialog.

So this sounds like a dup of bug 60280.  And to prove it, I went and applied the 
band-aid patch presented in that bug report and it did indeed stop the double 
dialogs.  I tried analyzing the html content to see if they were indeed doing a 
similar unorthodox thing as was done in the html content of 60280 but this 
content was so unorganized (javascript occuring in the middle of tables, etc) 
that I decided such an analysis was not worth the time.

But after I applied the band-aid I still got double dialogs but now only one was 
the password-manager dialog (the patch prevented the second one) and the other 
was the submitting-to-an-insecure-site dialog.  So this demonstrates that the 
band-aid patch of bug 60280 is insufficient (it is specifically tailored to 
preventing double password-manager dialogs) and the more general fix that danm 
is proposing should continue to be persued.

Finally I was able to catch the security dialog and check of the checkbox saying 
do not show this dialog again.  Restarted the browser and tried again.  Only one 
password manager dialog this time.  But I got into a state whereby after I 
clicked on the NO button the dialog would lose focus but it didn't vanish.  And 
clicking on the dialog again did not make it regain focus.  That's bug 53598 and 
it's intermittent.

And, finally, I did notice that the original URL never really finished loading.  
I had to click on the stop button to get the throbber to stop flashing.  But 
that's probably bug 53956.

Buttom line is that this is for the most part a dup of 60280 with the flavor of 
a few other bugs thrown in.

*** This bug has been marked as a duplicate of 60280 ***

Comment 3

[Stephen P. Morse]

Correction, the regain focus bug is bug 53589, not 53598

Comment 4

[selmer (gone)]

Steve, we left the fix for 60280 out of the branch because we couldn't dup the
problem.  Does this mean it's back and we'll have the problem on the branch
after all?

Comment 5

[Stephen P. Morse]

I thought we left it out of the branch because we could no longer duplicate the 
problem on the AOL server.  That's what would have made it a crucial problem to 
take the risk of a branch fix.

We were certainly able to duplicate the problem with the simplified example 
presented in the 60280 bug report and that's why that bug report is still open.  
And now we can demonstrate it on this site as well.  So it definitely should be 
fixed on the trunk in the right manner (as proposed by danm) for future 
releases.  But since it no longer occurs on AOL, it's not that crucial to 
netscape that we needed a band-aid fix on the branch.

Comment 6

[Stephen P. Morse]

cc'ing selmer so he can see the reponse to his question.

Comment 7

[selmer (gone)]

Sorry, I didn't note the difference in URL.  

Comment 8

[Terri Preston]

Verified Duplicate