664892 - Port bug 644861 (set --enable-application to mail by default) and bug 636695 (set enable-debug-symbols to on by default) to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch v1

This makes sense I think, and should allow a straightforward configure && make build.

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 539947 [details] [diff] [review]
patch v1

I'm of the mindset that while I do want simple builds, since we (comm-central) are used for two main and popular configs (suite and tb) we probably still want --enable-application required.

I'm deferring actual review to KaiRo as c-c build-system-owner.

Comment 2

[Rain [:rain1] (inactive)]

Yeah, I'm not too fixated on that bit. Would be nice to have a configure && make build though.

Comment 3

[Robert Kaiser]

Comment on attachment 539947 [details] [diff] [review]
patch v1

I'm actually OK with this, but with one caveat: In the case where we automatically set "mail", we should tell the user about it - please make it print something like "Building Thunderbird by default, set --enable-application if you want a different application."

(Callek, note that m-c nowadays also builds both Firefox and Fennec - and having a default doesn't make things more difficult for people building SeaMonkey.)

Comment 4

[Justin Wood (:Callek)]

(In reply to comment #3)
> (Callek, note that m-c nowadays also builds both Firefox and Fennec - and
> having a default doesn't make things more difficult for people building
> SeaMonkey.)

Yes of course, I just feel that Fennec is nowhere near as common a build config as Firefox ;-)

But I guess we could say the same about TB vs SeaMonkey. And in this case I'm not strongly opposed, and figured it best to leave the choice up to you.

Comment 5

[Rain [:rain1] (inactive)]

Too bad autoconf 2.13 doesn't have AC_MSG_NOTICE.

https://hg.mozilla.org/comm-central/rev/8a5612882e86