Port bug 644861 (set --enable-application to mail by default) and bug 636695 (set enable-debug-symbols to on by default) to comm-central

RESOLVED FIXED in Thunderbird 7.0

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: rain1, Assigned: rain1)

Tracking

unspecified
Thunderbird 7.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch patch v1Splinter Review
This makes sense I think, and should allow a straightforward configure && make build.
Attachment #539947 - Flags: review?(bugspam.Callek)
Assignee: nobody → sid.bugzilla
Comment on attachment 539947 [details] [diff] [review]
patch v1

I'm of the mindset that while I do want simple builds, since we (comm-central) are used for two main and popular configs (suite and tb) we probably still want --enable-application required.

I'm deferring actual review to KaiRo as c-c build-system-owner.
Attachment #539947 - Flags: review?(bugspam.Callek) → review?(kairo)
Yeah, I'm not too fixated on that bit. Would be nice to have a configure && make build though.
Comment on attachment 539947 [details] [diff] [review]
patch v1

I'm actually OK with this, but with one caveat: In the case where we automatically set "mail", we should tell the user about it - please make it print something like "Building Thunderbird by default, set --enable-application if you want a different application."

(Callek, note that m-c nowadays also builds both Firefox and Fennec - and having a default doesn't make things more difficult for people building SeaMonkey.)
Attachment #539947 - Flags: review?(kairo) → review+
(In reply to comment #3)
> (Callek, note that m-c nowadays also builds both Firefox and Fennec - and
> having a default doesn't make things more difficult for people building
> SeaMonkey.)

Yes of course, I just feel that Fennec is nowhere near as common a build config as Firefox ;-)

But I guess we could say the same about TB vs SeaMonkey. And in this case I'm not strongly opposed, and figured it best to leave the choice up to you.
Too bad autoconf 2.13 doesn't have AC_MSG_NOTICE.

https://hg.mozilla.org/comm-central/rev/8a5612882e86
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in before you can comment on or make changes to this bug.