Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
--
blocker
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Trunk
mozilla8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 539969 [details] [diff] [review]
Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds

Use MOZ_CHROME_FILE_FORMAT=symlink when omnijar is enabled.
Attachment #539969 - Flags: review?(ted.mielczarek)
Comment on attachment 539969 [details] [diff] [review]
Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds

Review of attachment 539969 [details] [diff] [review]:
-----------------------------------------------------------------

This should be fine, although I'm slightly worried about the fact that we added hardlink support for Windows to JarMaker.py. In bug 574183 we hit some crazy MSYS bug that caused bad things to happen (see bug 642931). Maybe we should back out the JarMaker patch first?
Attachment #539969 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 541883 [details] [diff] [review]
Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds, v2

sid0 wasn't so sure that this would be safe either, so I'm making this only apply to non-windows.
Attachment #539969 - Attachment is obsolete: true
Attachment #541883 - Flags: review?(ted.mielczarek)
Comment on attachment 541883 [details] [diff] [review]
Use MOZ_CHROME_FILE_FORMAT=symlink for omnijar builds, v2

The syntax looks fine to me. rs=Mitch
Attachment #541883 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/projects/build-system/rev/6947bbce9672
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/6947bbce9672
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Backed out during investigation of Android browser-chrome test failures:
http://hg.mozilla.org/mozilla-central/rev/00bb08972e46
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-bs
Target Milestone: mozilla7 → ---
(Assignee)

Comment 7

6 years ago
Created attachment 546996 [details] [diff] [review]
Move *.properties comment stripping to staging
Attachment #546996 - Flags: review?(khuey)
(Assignee)

Comment 8

6 years ago
Created attachment 546998 [details] [diff] [review]
Don't link to self when dealing with files in the object directory

When using files in the current working directory, JarMaker.py uses '.' as the base directory, which ends up giving us links like bookmarks.json -> ./bookmarks.json . This replaces '.' with the actual working directory to give us proper symlinks.
Attachment #546998 - Flags: review?(khuey)
Attachment #546998 - Flags: review?(khuey) → review+
Attachment #546996 - Flags: review?(khuey) → review+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d6fe12d237b0
http://hg.mozilla.org/integration/mozilla-inbound/rev/dd550792ca90
http://hg.mozilla.org/integration/mozilla-inbound/rev/95eda84ea6ba
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/d6fe12d237b0
http://hg.mozilla.org/mozilla-central/rev/dd550792ca90
http://hg.mozilla.org/mozilla-central/rev/95eda84ea6ba
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8

Updated

6 years ago
Depends on: 677068

Comment 11

6 years ago
This may have broken Android multilocale builds.

Updated

6 years ago
Depends on: 674830

Comment 12

6 years ago
(In reply to Aki Sasaki [:aki] from comment #11)
> This may have broken Android multilocale builds.

Verified; this broke Android multilocale builds.
https://bugzilla.mozilla.org/show_bug.cgi?id=674830#c32

(In reply to Marco Bonardo [:mak] (Away 8-14 Aug) from comment #10)
> http://hg.mozilla.org/mozilla-central/rev/d6fe12d237b0
> http://hg.mozilla.org/mozilla-central/rev/dd550792ca90
> http://hg.mozilla.org/mozilla-central/rev/95eda84ea6ba

Please back these out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 13

6 years ago
(In reply to Aki Sasaki [:aki] from comment #12)
> Please back these out.

Gonna make a patch to disable this on android, h/o.
(Assignee)

Comment 14

6 years ago
Created attachment 551944 [details] [diff] [review]
Exclude android

Probably won't be around to commit this patch.
Attachment #551944 - Flags: review?(khuey)

Comment 15

6 years ago
Please either land attachment 551944 [details] [diff] [review] as a bustage fix, even if review is still pending, or back out the changesets mentioned in comment 12.

Firefox Mobile is completely broken because of this, see bug 674830.
Keywords: checkin-needed
Whiteboard: [inbound]
Attachment #551944 - Flags: feedback+

Updated

6 years ago
Severity: normal → blocker
(Assignee)

Comment 16

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/1d071e2fa07f
Keywords: checkin-needed
Whiteboard: [inbound]
Comment on attachment 551944 [details] [diff] [review]
Exclude android

Bookkeeping at this point, but r=me.
Attachment #551944 - Flags: review?(khuey) → review+
Android fix landed on m-c for Firefox 8:
https://hg.mozilla.org/mozilla-central/rev/1d071e2fa07f
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
(In reply to Matt Brubeck (:mbrubeck) from comment #18)
> Android fix landed on m-c for Firefox 8:
> https://hg.mozilla.org/mozilla-central/rev/1d071e2fa07f

Verified Fixed the locale bustage
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110813 Firefox/8.0a1 Fennec/8.0a1
You need to log in before you can comment on or make changes to this bug.