664967 - Remove channel switching UI (Port bug 659972)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #659972 +++

I think we should follow what Firefox have done in removing the channel switching UI - especially as they are going to remove backend support for it as well (bug 660038).

For aurora I suggest we follow what Firefox has done - remove the UI keeping the strings. The only thing we need to be careful about there is that we keep the "Earlybird" as the display name on the aurora channel.

For central, we can just remove everything.

Protz: could you take this on? Should be quite simple.

Comment 1

[Robert Strong (they/them - no direct email)]

note: I might not remove the backend support and will decide at sometime in the future

Comment 2

[Jonathan Protzenko [:protz]]

Taking this. I'm fairly busy right now as I'm killing off the last bugs before the final, stable release of Conversations, but I'll tackle this bug as soon as conversations is published.

Comment 3

[Mark Banner (:standard8)]

Attachment: Remove the channel switching UI but keep the strings in place

This removes the channel switching UI in the same way as Firefox did it, i.e. keeping the line about which channel a user is on.

This doesn't remove the en-US strings, I'll add a separate patch for that which will handle that and can land on just comm-central.

I'd like to get this in asap as it is currently one of the things blocking releasing the next comm-beta release, so let me know if you can't review it quickly.

Comment 4

[Mark Banner (:standard8)]

Attachment: Remove the en-US strings

Comment 5

[Rain [:rain1] (inactive)]

Comment on attachment 545373 [details] [diff] [review]
Remove the channel switching UI but keep the strings in place

I haven't tested this, but assuming the changes are the same as in Firefox, this looks fine.

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/55631bb5a28f

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 545373 [details] [diff] [review]
Remove the channel switching UI but keep the strings in place

We also want this patch for 6 and 7.

Comment 8

[Mark Banner (:standard8)]

Landed on aurora and beta:

http://hg.mozilla.org/releases/comm-aurora/rev/a555dac15d90
http://hg.mozilla.org/releases/comm-beta/rev/66d32a9fd7a3