666232 - Smaller resize grips on Linux

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: mockup

Similar to what we've done on the Windows theme recently, it would be nice to replace the big clunky grip areas with a single line (with a regular sized resize area)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Make the splitter 1px wide/heigh

This is mostly a 1 to 1 copy of the aero splitters.

Comment 2

[Andreas Nilsson (:andreasn)]

Comment on attachment 543197 [details] [diff] [review]
Make the splitter 1px wide/heigh

Testing under Clearlooks, it looks like we lost the line under the folder view switcher in the folder pane as well as the line above the status bar. It also looks like there is a double line when the folder pane gains a scrollbar.

Comment 3

[Andreas Nilsson (:andreasn)]

We also need to figure out if we should do some kind of sidebar color (and what color that should be/what we can use).

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Make the splitter 1px wide/heigh V2

I was to enthusiastic with removing the borders. Now this should look better. In composer under Clearlooks the border under the addressing-widget/Format-toolbar looks a little bit thick but this is needed because under other themes a border would be missing, but this is also the same before this patch.

About the double line. For me it looks only as the border of the scrollbar. Can you show a screenshot? What do you propose what I can do here?

Comment 5

[Richard Marti (:Paenglab)]

(In reply to comment #3)
> We also need to figure out if we should do some kind of sidebar color (and
> what color that should be/what we can use).

With Darklooks or Hight Contrast theme this could give problems. Maybe with a alpha blended color (rgba(0,0,0,0.2)) this could be made. But this should be an other bug.

Comment 6

[Andreas Nilsson (:andreasn)]

(In reply to comment #5)
> (In reply to comment #3)
> > We also need to figure out if we should do some kind of sidebar color (and
> > what color that should be/what we can use).
> 
> With Darklooks or Hight Contrast theme this could give problems. Maybe with
> a alpha blended color (rgba(0,0,0,0.2)) this could be made. But this should
> be an other bug.

Yup, filed bug #669285 about that.

Comment 7

[Andreas Nilsson (:andreasn)]

Comment on attachment 543811 [details] [diff] [review]
Make the splitter 1px wide/heigh V2

Having ran with this all day it works very well in 3-pane window, composition window (with contacts sidebar) and address book. Nice work!
ui-r+

Comment 8

[Jonathan Protzenko [:protz]]

Comment on attachment 543811 [details] [diff] [review]
Make the splitter 1px wide/heigh V2

Review of attachment 543811 [details] [diff] [review]:
-----------------------------------------------------------------

So all in all the patch does look great. The CSS changes seem to be alright, and while I haven't checked the effect of every single CSS lines, it seems alright. Some remarks that I'd like to see addressed before committing this:
- it looks like the position:relative lines are actually needed, but I fail to understand why; maybe a comment?
- there's a whole bunch of min-width: 0 which confuse me highly; as you explain, they're overriding a previous style rule, but a comment next to the first occurrence would certainly help.

Once toolbars start to appear, it doesn't look that nice anymore (see http://jonathan.protzenko.free.fr/shutter/Selection_012.png) but I guess there's not much we can do here, since the scrollbars a very much dependent on the Gtk theme on Linux.

r=me with the extra comments. Thanks for your work!

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in addressing comment

I removed the min-height/min-width: 0 because this was only needed on Windows.

I gave this comments:
  -moz-border-end: 1px solid ThreeDShadow;
  /* splitter grip area */
  width: 4px;
  /* make only the splitter border visible */
  -moz-margin-start: -4px;
  /* because of the negative margin needed to make the splitter visible */
  position: relative;

I hope this is okay like this.

Comment 10

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/946b956a9bad

Comment 11

[Jim Porter (:squib)]

Attachment: Make the attachment splitter 1px in the standalone message window

I just noticed that the splitter for the attachment pane in the standalone message window wasn't touched by this bug, so here's a patch to do that too.

Comment 12

[Jonathan Protzenko [:protz]]

Comment on attachment 548032 [details] [diff] [review]
Make the attachment splitter 1px in the standalone message window

Review of attachment 548032 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this. I somehow forgot about the standalone message window and so did Richard... guess we're not big users of the standalone message window!

Comment 13

[Andreas Nilsson (:andreasn)]

checkin-needed?

Comment 14

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/a005672d01ad