668058 - Add a DIR_INSTALL nsinstall shortcut, and allow $(INSTALL) to support target-specific makefiles

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch v1

We're going to need this to import MozMill and its dependencies into the tree. The two are related because sometimes in our case, we'd like to recursively copy over the files and not symlink it (since setuptools likes to create garbage in the srcdir).

This passed try server.

Comment 1

[Rain [:rain1] (inactive)]

Attachment: patch v2

This patch checks for WINNT/OS2 the same way TEST_INSTALLER used to.

Comment 2

[Rain [:rain1] (inactive)]

See bug 668053 for the m-c version. I talked to Ted and he seemed happy with the idea in general.

Comment 3

[Rain [:rain1] (inactive)]

I'm thinking something like DIR_INSTALL might be a better name, since we might either symlink it or recursively copy it.

Comment 4

[Rain [:rain1] (inactive)]

Callek, will you be able to review this?

Comment 5

[Rain [:rain1] (inactive)]

Comment on attachment 542641 [details] [diff] [review]
patch v2

whoever gets to it first :)

Comment 6

[Rain [:rain1] (inactive)]

Ted was undecided about whether to switch to DIR_INSTALL, so I went ahead.

https://hg.mozilla.org/projects/build-system/rev/aeb17d9bdc0d

Comment 7

[Rain [:rain1] (inactive)]

Oops, I should have posted that to bug 668053. (Fail.)

Comment 8

[Rain [:rain1] (inactive)]

I've switched over RECURSIVE_INSTALL to DIR_INSTALL locally...

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 542641 [details] [diff] [review]
patch v2

r+ if you apply the followup of bug 670249 to c-c as well, and if you do as m-c and use DIR_INSTALL rather than RECURSIVE_INSTALL

Comment 10

[Rain [:rain1] (inactive)]

https://hg.mozilla.org/comm-central/rev/4579fdf3d436

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/aeb17d9bdc0d