Closed Bug 669504 Opened 8 years ago Closed 8 years ago

Port bug 649373 - remove the PRE_RELEASE_SUFFIX so that nightly/aurora builds don't have Alpha in their window titles

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(thunderbird6+ fixed, thunderbird7+ fixed)

RESOLVED FIXED
Thunderbird 8.0
Tracking Status
thunderbird6 + fixed
thunderbird7 + fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

From bug 649373:

(In reply to comment #0)
> Aurora blank windows have "Alpha 2" in the title. Aurora will always have
> [version]a2 as its version. We should remove the "Alpha 2"

(In reply to comment #3)
> My understanding from #developers is that the actual summary should be "Drop
> the whole PRE_RELEASE_SUFFIX thing."
> 
> mozilla-central will always be n.0a1, never pre, and never released or
> branded, so a screenshot with "Nightly" in the titlebar can't be confused
> with anything; mozilla-aurora will always be n.0a2, never pre, never
> branded, and we're fine with having no way to tell the difference between a
> screenshot of a shipped Aurora and a tinderbox-build Aurora; mozilla-beta
> will always be n.0, never pre, always branded, and we're fine with having no
> way to tell the difference between a screenshot of the very first
> tinderbox-build from mozilla-beta and the final release of Firefox n.0.

I think it is reasonable that we do the same for Thunderbird - it is a bit strange that it says Alpha 1/Alpha 2 when it is always that according to the branch, and the branding will tell us the difference between branches anyway.
Attached patch The fixSplinter Review
This blanks the pre-release suffix like Firefox did. The removals in jquery land are just because jquery doesn't get preprocessed at all, so it is pointless putting additional pre-process variables in there.
Attachment #544190 - Flags: review?(bwinton)
Comment on attachment 544190 [details] [diff] [review]
The fix

Blake said he's happy with the idea, and I'd like to get this hitting the branches fairly soon, especially as we can't do first beta until we get it.
Attachment #544190 - Flags: review?(bwinton) → review?(dbienvenu)
Attachment #544190 - Flags: review?(dbienvenu) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/3ac94faeeb55
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0
Attachment #544190 - Flags: approval-comm-beta+
Attachment #544190 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.