remove atlbase.h check from configure

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: m_kato, Assigned: Matheus Kerschbaum)

Tracking

({dev-doc-complete})

Trunk
mozilla9
x86
Windows Vista
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Since ActiveX support is dropped and accessibility support doesn't need ATL now, I think we can remove atlbase.h checking from configure.
Docs could be updated/flagged as legacy after configure is changed:
  http://developer.mozilla.org/en/atlbase.h

Moot item if the header check is removed -- windows7 may not be paying attention to the --disable- flag.

>> ac_add_options --disable-accessibility
(Reporter)

Comment 2

6 years ago
Humm, we still only use ATL header into breakpad although we don't use atlbase.h

http://mxr.mozilla.org/mozilla-central/search?string=atlcomcli.h

IPC code that include atlcomcli.h isn't build target. (Makefile doesn't have win_safe_util.cc entry).

(In reply to comment #1)
> Docs could be updated/flagged as legacy after configure is changed:
>   http://developer.mozilla.org/en/atlbase.h
> 
> Moot item if the header check is removed -- windows7 may not be paying
> attention to the --disable- flag.
> 
> >> ac_add_options --disable-accessibility

This document is invalid now.
(In reply to comment #2)
> Humm, we still only use ATL header into breakpad although we don't use
> atlbase.h

That Breakpad code is part of dump_syms, which we don't build as part of the build (we have prebuilt binaries in the tree).
(Assignee)

Updated

6 years ago
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
(Assignee)

Comment 4

6 years ago
Created attachment 560741 [details] [diff] [review]
patch
Attachment #560741 - Flags: review?(ted.mielczarek)
Attachment #560741 - Flags: review?(ted.mielczarek) → review+
(In reply to Joey Armstrong [:joey] from comment #1)
> Docs could be updated/flagged as legacy after configure is changed:
>   http://developer.mozilla.org/en/atlbase.h

Seems fine to note that this doc is outdated, but we should leave it there because we linked to it from the configure error in older versions.
(Assignee)

Updated

6 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Keywords: dev-doc-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec384fc33769
Keywords: checkin-needed
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/ec384fc33769
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Documentation updated:

https://developer.mozilla.org/en/atlbase.h
Keywords: dev-doc-needed → dev-doc-complete
Duplicate of this bug: 614504
Duplicate of this bug: 674870
You need to log in before you can comment on or make changes to this bug.