669829 - remove atlbase.h check from configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

Since ActiveX support is dropped and accessibility support doesn't need ATL now, I think we can remove atlbase.h checking from configure.

Comment 1

[Joey Armstrong [:joey]]

Docs could be updated/flagged as legacy after configure is changed:
  http://developer.mozilla.org/en/atlbase.h

Moot item if the header check is removed -- windows7 may not be paying attention to the --disable- flag.

>> ac_add_options --disable-accessibility

Comment 2

[Makoto Kato [:m_kato]]

Humm, we still only use ATL header into breakpad although we don't use atlbase.h

http://mxr.mozilla.org/mozilla-central/search?string=atlcomcli.h

IPC code that include atlcomcli.h isn't build target. (Makefile doesn't have win_safe_util.cc entry).

(In reply to comment #1)
> Docs could be updated/flagged as legacy after configure is changed:
>   http://developer.mozilla.org/en/atlbase.h
> 
> Moot item if the header check is removed -- windows7 may not be paying
> attention to the --disable- flag.
> 
> >> ac_add_options --disable-accessibility

This document is invalid now.

Comment 3

[(not currently active) Ted Mielczarek]

(In reply to comment #2)
> Humm, we still only use ATL header into breakpad although we don't use
> atlbase.h

That Breakpad code is part of dump_syms, which we don't build as part of the build (we have prebuilt binaries in the tree).

Comment 4

[Matheus Kerschbaum]

Attachment: patch

Comment 5

[(not currently active) Ted Mielczarek]

(In reply to Joey Armstrong [:joey] from comment #1)
> Docs could be updated/flagged as legacy after configure is changed:
>   http://developer.mozilla.org/en/atlbase.h

Seems fine to note that this doc is outdated, but we should leave it there because we linked to it from the configure error in older versions.

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec384fc33769

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ec384fc33769

Comment 8

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/atlbase.h