Closed
Bug 669829
Opened 13 years ago
Closed 13 years ago
remove atlbase.h check from configure
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: m_kato, Assigned: matjk7)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
2.81 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Since ActiveX support is dropped and accessibility support doesn't need ATL now, I think we can remove atlbase.h checking from configure.
Comment 1•13 years ago
|
||
Docs could be updated/flagged as legacy after configure is changed: http://developer.mozilla.org/en/atlbase.h Moot item if the header check is removed -- windows7 may not be paying attention to the --disable- flag. >> ac_add_options --disable-accessibility
Reporter | ||
Comment 2•13 years ago
|
||
Humm, we still only use ATL header into breakpad although we don't use atlbase.h http://mxr.mozilla.org/mozilla-central/search?string=atlcomcli.h IPC code that include atlcomcli.h isn't build target. (Makefile doesn't have win_safe_util.cc entry). (In reply to comment #1) > Docs could be updated/flagged as legacy after configure is changed: > http://developer.mozilla.org/en/atlbase.h > > Moot item if the header check is removed -- windows7 may not be paying > attention to the --disable- flag. > > >> ac_add_options --disable-accessibility This document is invalid now.
Comment 3•13 years ago
|
||
(In reply to comment #2) > Humm, we still only use ATL header into breakpad although we don't use > atlbase.h That Breakpad code is part of dump_syms, which we don't build as part of the build (we have prebuilt binaries in the tree).
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•13 years ago
|
||
Attachment #560741 -
Flags: review?(ted.mielczarek)
Updated•13 years ago
|
Attachment #560741 -
Flags: review?(ted.mielczarek) → review+
Comment 5•13 years ago
|
||
(In reply to Joey Armstrong [:joey] from comment #1) > Docs could be updated/flagged as legacy after configure is changed: > http://developer.mozilla.org/en/atlbase.h Seems fine to note that this doc is outdated, but we should leave it there because we linked to it from the configure error in older versions.
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite-
Keywords: checkin-needed
Updated•13 years ago
|
Keywords: dev-doc-needed
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec384fc33769
Keywords: checkin-needed
Target Milestone: --- → mozilla9
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ec384fc33769
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 8•13 years ago
|
||
Documentation updated: https://developer.mozilla.org/en/atlbase.h
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•