671921 - Minor string change: "Double check" in New Account Wizard should probably be hyphenated

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Daniel Holbert [:dholbert]]

This string (which appears after performing STR in bug 671917)...
>  double_check_email=Double check this email address!
...probably wants to say "Double-check this email address!"
(needs a hyphen between "Double" and "check")

Link to source:
http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/chrome/messenger/accountCreation.properties#67

Justification:
==============
* http://dictionary.reference.com/browse/double+check says that the non-hyphenated version refers to a particular move in chess, whereas the hyphenated version has the meaning that we clearly intend.

* http://www.kcitraining.com/styleguide/hyphens.html says "Two or more words that act together to form a new meaning are hyphenated" and gives double-check as an example. (no idea how authoritative kcitraining.com is, but their explanation seems to make sense)

Comment 1

[Ludovic Hirlimann [:Usul]]

Blake can you ui-r? this idea ?

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Not without a patch…  But yeah, I would buy a hyphen between double and check.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix: s/Double check/Double-check/

Ok, here's a patch. :)

(Let me know if there are any other reviews/approvals I should request on this)

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 547964 [details] [diff] [review]
fix: s/Double check/Double-check/

Review of attachment 547964 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, ui-r=me, and r=me if you can get a localizer to comment that we don't need to change the name of the string.

(r- if we do need to change the name of the string for localization purposes, of course.  ;)

Comment 5

[Daniel Holbert [:dholbert]]

Ok! I don't see why this would require a string-name-change. (but I don't know much about l10n)

Perhaps Axel can confirm my assumption (or suggest someone who could)?

Comment 6

[Francesco Lodolo [:flod]]

(In reply to comment #4)
> Looks good, ui-r=me, and r=me if you can get a localizer to comment that we
> don't need to change the name of the string.

You're fixing a typo in your language and that doesn't change the meaning of the string, so I don't see any need to change the entity's name.

Comment 7

[Axel Hecht [:Pike]]

What flod said. Good as is.

Comment 8

[Daniel Holbert [:dholbert]]

Thanks! Landed: http://hg.mozilla.org/comm-central/rev/fb61d037609a

(In reply to comment #6)
> You're fixing a typo in your language and that doesn't change the meaning of
> the string, so I don't see any need to change the entity's name.

Does that mean the "[has l10n impact]" whiteboard status can be cleared?

Comment 9

[Axel Hecht [:Pike]]

Depends on what you use it for, I guess.

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to Daniel Holbert [:dholbert] from comment #8)
> Thanks! Landed: http://hg.mozilla.org/comm-central/rev/fb61d037609a
> 
> (In reply to comment #6)
> > You're fixing a typo in your language and that doesn't change the meaning of
> > the string, so I don't see any need to change the entity's name.
> 
> Does that mean the "[has l10n impact]" whiteboard status can be cleared?

Yes