672046 - Valgrind suppression files are still generated in objdir even when building without --enable-valgrind

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

Bug 631841 moved the Valgrind suppression files into m-c, but the build system changes made there don't check whether --enable-valgrind is set or not. 

This results in the |_valgrind| folder (containing suppression files) being generated in the objdir during the build even when valgrind is not enabled (which is the current default).

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Does this really matter?

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Adds AC_SUBST(MOZ_VALGRIND) to configure.in to allow an |ifdef MOZ_VALGRIND| in /build/Makefile.in

Running past try shortly.

Comment 3

[Ed Morley [:emorley]]

(In reply to comment #1)
> Does this really matter?

If it were anything other than a ~6 line change, perhaps not. Happened to notice it when dealing with bug 672040.

Comment 4

[Ed Morley [:emorley]]

http://dev.philringnalda.com/tbpl/?tree=Try&rev=145f59772117

Comment 5

[Ed Morley [:emorley]]

The previous try pass was broken by one of the other changesets in the push. Submitted again without that and passed:
http://dev.philringnalda.com/tbpl/?tree=Try&rev=556cec8038c2

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 546324 [details] [diff] [review]
Patch v1

Review of attachment 546324 [details] [diff] [review]:
-----------------------------------------------------------------

I'm kind of with khuey in that I don't think this matters much, but I don't really care either way and you've already written the patch.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/452be6a8b6e4

Comment 8

[(not currently active) Ted Mielczarek]

MOZ_VALGRIND isn't defined in autoconf.mk.in, so this doesn't actually work. :-/

Comment 9

[Ed Morley [:emorley]]

Whoops, sorry!