Last Comment Bug 672046 - Valgrind suppression files are still generated in objdir even when building without --enable-valgrind
: Valgrind suppression files are still generated in objdir even when building w...
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla8
Assigned To: Ed Morley [:emorley]
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on: 696297
Blocks: 631841
  Show dependency treegraph
Reported: 2011-07-16 07:53 PDT by Ed Morley [:emorley]
Modified: 2012-04-27 05:39 PDT (History)
4 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (2.70 KB, patch)
2011-07-16 07:57 PDT, Ed Morley [:emorley]
ted: review+
Details | Diff | Splinter Review

Description User image Ed Morley [:emorley] 2011-07-16 07:53:43 PDT
Bug 631841 moved the Valgrind suppression files into m-c, but the build system changes made there don't check whether --enable-valgrind is set or not. 

This results in the |_valgrind| folder (containing suppression files) being generated in the objdir during the build even when valgrind is not enabled (which is the current default).
Comment 1 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-07-16 07:56:12 PDT
Does this really matter?
Comment 2 User image Ed Morley [:emorley] 2011-07-16 07:57:45 PDT
Created attachment 546324 [details] [diff] [review]
Patch v1

Adds AC_SUBST(MOZ_VALGRIND) to to allow an |ifdef MOZ_VALGRIND| in /build/

Running past try shortly.
Comment 3 User image Ed Morley [:emorley] 2011-07-16 08:01:54 PDT
(In reply to comment #1)
> Does this really matter?

If it were anything other than a ~6 line change, perhaps not. Happened to notice it when dealing with bug 672040.
Comment 4 User image Ed Morley [:emorley] 2011-07-16 09:57:41 PDT
Comment 5 User image Ed Morley [:emorley] 2011-07-16 15:35:14 PDT
The previous try pass was broken by one of the other changesets in the push. Submitted again without that and passed:
Comment 6 User image Ted Mielczarek [:ted.mielczarek] 2011-07-19 09:08:58 PDT
Comment on attachment 546324 [details] [diff] [review]
Patch v1

Review of attachment 546324 [details] [diff] [review]:

I'm kind of with khuey in that I don't think this matters much, but I don't really care either way and you've already written the patch.
Comment 7 User image :Ms2ger (⌚ UTC+1/+2) 2011-07-23 06:54:21 PDT
Comment 8 User image Ted Mielczarek [:ted.mielczarek] 2012-04-27 05:19:37 PDT
MOZ_VALGRIND isn't defined in, so this doesn't actually work. :-/
Comment 9 User image Ed Morley [:emorley] 2012-04-27 05:39:35 PDT
Whoops, sorry!

Note You need to log in before you can comment on or make changes to this bug.