Valgrind suppression files are still generated in objdir even when building without --enable-valgrind

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 631841 moved the Valgrind suppression files into m-c, but the build system changes made there don't check whether --enable-valgrind is set or not. 

This results in the |_valgrind| folder (containing suppression files) being generated in the objdir during the build even when valgrind is not enabled (which is the current default).

Updated

6 years ago
Blocks: 672045
Does this really matter?
No longer blocks: 672045
(Assignee)

Comment 2

6 years ago
Created attachment 546324 [details] [diff] [review]
Patch v1

Adds AC_SUBST(MOZ_VALGRIND) to configure.in to allow an |ifdef MOZ_VALGRIND| in /build/Makefile.in

Running past try shortly.
Attachment #546324 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

6 years ago
(In reply to comment #1)
> Does this really matter?

If it were anything other than a ~6 line change, perhaps not. Happened to notice it when dealing with bug 672040.
(Assignee)

Comment 4

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=145f59772117
(Assignee)

Comment 5

6 years ago
The previous try pass was broken by one of the other changesets in the push. Submitted again without that and passed:
http://dev.philringnalda.com/tbpl/?tree=Try&rev=556cec8038c2
(Assignee)

Updated

6 years ago
Flags: in-testsuite-
Comment on attachment 546324 [details] [diff] [review]
Patch v1

Review of attachment 546324 [details] [diff] [review]:
-----------------------------------------------------------------

I'm kind of with khuey in that I don't think this matters much, but I don't really care either way and you've already written the patch.
Attachment #546324 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/452be6a8b6e4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Depends on: 696297
MOZ_VALGRIND isn't defined in autoconf.mk.in, so this doesn't actually work. :-/
(Assignee)

Comment 9

5 years ago
Whoops, sorry!
You need to log in before you can comment on or make changes to this bug.