Closed Bug 67219 Opened 25 years ago Closed 16 years ago

Disable filters menu item when no accounts are set up

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.0b4

People

(Reporter: gayatrib, Assigned: mkmelin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

proposed fix
7.44 KB, patch
standard8
: review+
clarkbw
: ui-review+
Details | Diff | Splinter Review
proposed fix, v2
1.31 KB, patch
standard8
: review+
Details | Diff | Splinter Review
No description provided.
Adding nsbeta1 keyword and accepting the bug.
Status: NEW → ASSIGNED
Keywords: nsbeta1
Adding Seth to cc list.
QA Contact: esther → laurel
OS: Windows NT → All
Hardware: PC → All
Summary: Disable filters menuitem when no server in any account can support filters. → Disable filters menu item when no server in any account supports filters
marking nsbeta1-
Keywords: nsbeta1 → nsbeta1-
Target Milestone: --- → Future
*** Bug 71006 has been marked as a duplicate of this bug. ***
reassigning to naving
Assignee: gayatrib → naving
Status: ASSIGNED → NEW
*** Bug 101671 has been marked as a duplicate of this bug. ***
*** Bug 111560 has been marked as a duplicate of this bug. ***
*** Bug 161754 has been marked as a duplicate of this bug. ***
mass re-assign.
Assignee: naving → sspitzer
Product: MailNews → Core
sorry for the spam. making bugzilla reflect reality as I'm not working on these bugs. filter on FOOBARCHEESE to remove these in bulk.
Assignee: sspitzer → nobody
Filter on "Nobody_NScomTLD_20080620"
QA Contact: laurel → filters
bienvenu speculates "bug might pre-date news filters"
Severity: normal → trivial
Product: Core → MailNews Core
Summary: Disable filters menu item when no server in any account supports filters → Disable filters menu item when no server in any account supports filters, or no accounts at all
Ok, let's only fix the no-accounts part.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Component: Filters → Mail Window Front End
Product: MailNews Core → Thunderbird
QA Contact: filters → front-end
Summary: Disable filters menu item when no server in any account supports filters, or no accounts at all → Disable filters menu item when no accounts are set up
Target Milestone: Future → Thunderbird 3.0b4
Attached patch proposed fix — — Splinter Review
Also fixed cmd_moveToFolderAgain which wasn't too happy about no folder.
Attachment #388993 - Flags: review?(philringnalda)
Blocks: 495815
Comment on attachment 388993 [details] [diff] [review] proposed fix Pre-vacation request balancing - where the desired balance is "all weight on your shoulders, none on mine" :)
Attachment #388993 - Flags: review?(philringnalda) → review?(bugzilla)
Comment on attachment 388993 [details] [diff] [review] proposed fix I'm going to give this r=Standard8 and request ui-review from Bryan. I have no issues with disabling display of the message filters option when there are no accounts. What I would like to know is Bryan's thoughts on disabling the message filters option when we have non-mail tabs displaying, e.g. calendar/tasks/content. I expect it isn't really an issue, and probably benefits us in some cases (we don't have to work out which account to show the dialog with). I'm just not sure if there is a case for having it enabled on non-mail tabs.
Attachment #388993 - Flags: ui-review?(clarkbw)
Attachment #388993 - Flags: review?(bugzilla)
Attachment #388993 - Flags: review+
We'd just show the filters for the default account in that case, which is useful, so I'm not sure that's a benefit...
Comment on attachment 388993 [details] [diff] [review] proposed fix nice. > What I would like to know is Bryan's thoughts on disabling the message filters > option when we have non-mail tabs displaying, e.g. calendar/tasks/content. I > expect it isn't really an issue, and probably benefits us in some cases (we > don't have to work out which account to show the dialog with). I'm just not > sure if there is a case for having it enabled on non-mail tabs. Assuming we have accounts setup I don't think it will hurt to have this available in other non account/mail tabs. Though I imagine the use cases for it will be small.
Attachment #388993 - Flags: ui-review?(clarkbw) → ui-review+
changeset: 3135:af9acb8c6f0d http://hg.mozilla.org/comm-central/rev/af9acb8c6f0d ->FIXED Cloned as bug 506510 for seamonkey.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attached patch proposed fix, v2 — — Splinter Review
Better fix. The previous fix is wrong for when account central is showing.
Attachment #391815 - Flags: review?(bugzilla)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 391815 [details] [diff] [review] proposed fix, v2 That looks better.
Attachment #391815 - Flags: review?(bugzilla) → review+
changeset: 3211:73841d777c1b http://hg.mozilla.org/comm-central/rev/73841d777c1b ->FIXED
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: