Closed Bug 673003 Opened 10 years ago Closed 10 years ago

Handle \\\n in pymake

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Attached patch Patch?Splinter Review
In http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/9de1d1f4e4b1 bsmedberg blocklisted '\\\n'.  I'm not a shell expert, but we can just strip that out, right?

It's going to be pretty annoying if we have to mash all of our pymake native commands onto one line.
Attachment #547297 - Flags: review?(benjamin)
Duplicate of this bug: 585113
Comment on attachment 547297 [details] [diff] [review]
Patch?

Review of attachment 547297 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks fine, but you really need to add some tests. r=me with tests.
Attachment #547297 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/4a63f7834efe
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.