67359 - Need icons for mail thread pane icons for messages which have been downloaded for offline use

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[David :Bienvenu]

4.x had special icons for news and imap messages which had been downloaded for
offline use. we need those for 6.5 now.

Comment 1

[Jarrod Gray]

This may fit in here also... there would need to be an icon that shows whether a 
mail message has been cached on the local machine when using imap. MS Outlook 
has similar functionality.

Comment 2

[David :Bienvenu]

what you describe is exactly what this bug is for - we only cache messages
locally for offline use.

Comment 3

[Alexey Chernyak]

this is related to bug 22112

Comment 4

[scottputterman]

We're asking this late, but it would be great to have these for beta1.  This
would be a better solution in my opinion than making messages italicized.

Comment 5

[marlon bishop]

Gail agreed to help me out with these short term.  thanx gail!

Comment 6

[hangas]

Moving bug to Joe and marking 0.9.2, Joe has the icons from Gail.

Comment 7

[jglick]

Once the icons are available, this needs to go to an engineer so the icons are 
implemented correctly. 

Messages that have been downloaded locally should show the new icons, Not the 
italic text that is currently being used in the thread pane.

Comment 8

[Todd Pringle]

themes triage: moving to 0.9.3. P3

Comment 9

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 10

[andreww]

r=andreww

Comment 11

[David :Bienvenu]

sr=bienvenu

Comment 12

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 13

[Joe Hewitt (gone)]

fixed

Comment 14

[jglick]

So does this bug only get the icons checked in?  Does a separate bug need to be 
filed to get the icons to appear correctly and to removed the italics?

Comment 15

[jglick]

86460 filed to remove italics.

Comment 16

[grylchan]

So I am assuming since we still show the italics, that is the reason
why icons do not appear? if this is correct, I am going to
add a dependency on this bug to bug 86460. Since I can't verify
this bug until the other one is fixed. If am incorrect on this
assumpiton, please let me know.

Comment 17

[scottputterman]

I see different icons for downloaded messages using 2001061804 on Win 2000

Comment 18

[Joe Hewitt (gone)]

The italics a totally separate issue.

The icons are now correctly showing up for offline downloaded messages.  I can
confirm this with a 6/17 build.

Comment 19

[grylchan]

Ok. My bad. I'll remove the dependency..

I am using 2001061804 on Nt 4.0 and it doesn't seem to
work if you are in classic mode. Wasn't sure if
I should reopen this bug or file a new bug that is based just on the 
classic theme. So I am Reopening bug for now.

I have some comments with the offline icon in general.

I downloaded a folder that had about 10 messages.
I looked at the folder and couldn't tell it was downloaded
(if not for italic mode). I clicked on another folder
then clicked back and I still couldn't tell. Then
I read Scott's comments that he can see it. So I did
a double take and then I figured out the envelope color
(white downloaded, gray if it's not). I asked a fellow
coworker to see if he could tell if messages are downloaded or
not. So he downloaded a folder and he mentioned the italic
mode. He then mentioned different colored envelopes. But
the only reason why he mentioned the envelope is one of the
messages was > 50kb so it didn't get downloaded. If it wasn't for 
the bigger message not getting downloaded, 
he said he wouldn't have noticed.  

So would the average user notice? I don't think the icon sticks
out enough. Another color? It's definitely better than the 4.x icon 
that showed if the message was downloaded or not. For longest time
I didn't even know there was offline icon in 4.x. That icon was not
noticeable at all.

I guess not being part of the UI team or knowing what the actual
icon would actually look like, I was under a different impression.
I thought there was going to another column with some type of
offline indicator symbol (whatever that might be).

Not sure what others think or what the UI studies support.

Just thought I would voice my opinion on it. Sorry for the
Long Winded take....

Comment 20

[jglick]

It was done subtle on purpose. Anything that is local uses this different icon: 
messages in POP accounts, messages in local folders and messages that have been 
downloaded locally for IMAP accounts.  If the indication was something more 
intrusive like italics or a red icon or something, this could potentially be  
displayed for a large majority of some users messages (or all a user's messages 
if they only had POP accounts).  The goal was to have a more subtle indication, 
so that it wasn't distracting or confusing for users with a lot of local 
messages, or POP accts, etc., but still enough of a distinction for users to 
notice if they were interested in this feature.

Comment 21

[grylchan]

Ok thanks for the clarification Jennifer.

Comment 22

[jglick]

If you feel they are too subtle, let me know.

Comment 23

[Hong Kwon]

Attachment: Outlook's envelope icon

Comment 24

[Hong Kwon]

This is a (somewhat bizarrely stretched) screenshot of Outlook 2000's download
icon.  I don't believe it's intrusive at all, and it gives a much more intuitive
look at what happens when a message is downloaded.  Note that the messages that
are header-only have incomplete icons, and the ones that are completely
downloaded have full envelopes.  Personally I find this amazingly more useful
than either 4.x's shaded/unshaded envelope or 6.1's white/gray envelope.

Comment 25

[jglick]

Soundn't this bug remain closed since this was implemented as designed? And keep 
discussion of the icon design in bug 86897?

Comment 26

[grylchan]

That's fine Jennifer. I reopened the bug because
if you switch to classic theme, the offline
icon is not properly displayed. (Envelope is
white if its downloaded or not). If you or Joe
feel that this should be a new bug, I will file a new bug
on it and then verify this bug.

Comment 27

[jglick]

Ah, ok. Thanks for clarification.  Up to Joe if he wants a new bug for Classic 
issue.

Comment 28

[grylchan]

Just curious on what the decision is with this bug since
I reopened it.

Since the icon doesn't seem to work in Classic mode did
you want me to file a new bug? Or is it currently being
worked on? Thanks.

Comment 29

[Joe Hewitt (gone)]

I need to mark this fixed.  It's a 0.9.2 bug which WAS fixed.  If you wish to
improve the actual icons, please open another bug.

Comment 30

[Hong Kwon]

Please re-read this comment.  This bug is not fixed in Classic Skin.  Reopening.

>------- Additional Comments From [e-mail] 2001-06-20 11:27 -------
>
>That's fine Jennifer. I reopened the bug because
>if you switch to classic theme, the offline
>icon is not properly displayed. (Envelope is
>white if its downloaded or not). If you or Joe
>feel that this should be a new bug, I will file a new bug
>on it and then verify this bug.

Comment 31

[hangas]

Moving to 0.9.3 to keep on radar.

Comment 32

[grylchan]

Another question.

Originally when David created this bug it was intended
for both mail and news.

The fix was only applied to imap mail. Do we need to
open a seperate bug for news? Or when this gets
fixed in 9.3, it will be applied to both mail and
newsgroups. Also it would have to be applied
in classic theme also.

Comment 33

[jglick]

Please fill a separate bug for news icons. Icons need to be created first. 
Thanks.

Comment 34

[grylchan]

ooops forgot to add the news icon bug is bug 88970.

Comment 35

[Jussi-Pekka Mantere]

Removing nsenterprise nomination.

Comment 36

[Joe Hewitt (gone)]

giving to shuehan

Comment 37

[shliang]

Attachment: icons for classic

Comment 38

[shliang]

Attachment: patch for classic

some irrelevant stuff in there from something else

Comment 39

[andreww]

Comment on attachment 58745 [details]
icons for classic

the filename for one of the images is too long. If this jar was uncompressed on
mac this filename would get cut  off and the image would "break"

Comment 40

[andreww]

Comment on attachment 58746 [details] [diff] [review]
patch for classic

r=andreww - provided that one long filename is changed
(message-mail-imapdelete-offl.gif)

Comment 41

[Joe Hewitt (gone)]

Comment on attachment 58746 [details] [diff] [review]
patch for classic

sr=hewitt

Comment 42

[grylchan]

I was wondering if this fix has landed on the trunk yet?
I am seeing a possible regression in classic theme
with the envelope icon. It dissapears after a mesg
has been downloaded. Fine in modern theme.

Comment 43

[R.K.Aa.]

*** Bug 114992 has been marked as a duplicate of this bug. ***

Comment 44

[grylchan]

adding note, that currently in trunk builds, classic theme only,
envelope icons will dissapear when downloading mesgs. Both the
developer and qa are aware of this.

Comment 45

[grylchan]

*** Bug 118335 has been marked as a duplicate of this bug. ***

Comment 46

[shliang]

this is fixed

Comment 47

[grylchan]

Using commercial trunk builds:
2002-01-11-09-trunk Win nt 4.0
2002-01-11-08-trunk  linux 2.2, mac 9.1, mac 10.1

Verified that there is a download icon for mail messages in classic theme.

A dark (almost gray)envelope icon represents a downloaded mesg.
A white envelope icon represents a non-downloaded mesg.

Modern mail icons are fine.

And when you switch between themes, the downloaded mesg keeps
correct icon regardless of what theme it was originally downloaded in.

Marking as verified.