67427 - Crash when right clicking on bookmarks or history trees

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Anatoly Kochergin]

From Bugzilla Helper:
User-Agent: Mozilla/4.76 [en] (Windows NT 5.0; U)
BuildID:    2001020120

Mozilla crashed then I right click on any bookmark in "Managing Bookmarks" 
window. Problem still exists after reinstalling mozilla and 
creating new default profile.

Reproducible: Always
Steps to Reproduce:
1. Open mozilla.
2. Press Ctrl-B.
3. Click on any bookmark link by right mouse button.


Actual Results:  Crash.

Comment 1

[Martin Horwath]

confirmin' on win98 tested with same buildid

MOZILLA.EXE caused fault #c0000005 in GKHTML.DLL at address 0187:602b776d

Comment 2

[Håkan Waara]

Platform: PC
OS: Windows 98
Build: 20010201 trunk build.

Worksforme.

Comment 3

[Fabian Guisset]

ben did you check in anything yet for the new bookmarks window that could have
created a conflict?
crash and regression keyw

Comment 4

[Gilles Durys]

It happens on linux too.
Platform, Os -> All

Comment 5

[Gregory McLean]

Linux 2001020206 crashes on this also, Talkback ID TB25688580X

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Log of crash.

Comment 7

[Peter Trudelle]

nominating for mozilla0.8

Comment 8

[Blake Ross]

-> hyatt

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 67552 has been marked as a duplicate of this bug. ***

Comment 10

[John Bandhauer]

Attachment: win32 stack - crashes because document is null

Comment 11

[R.K.Aa.]

also happens second time you click File-menu in composer - same bt

Comment 12

[R.K.Aa.]

*** Bug 67632 has been marked as a duplicate of this bug. ***

Comment 13

[Asko Tontti]

If this helps:

Linux 2001020108: worksforme
Linux 2001020121: crash

Comment 14

[Stephen Walker]

*** Bug 67638 has been marked as a duplicate of this bug. ***

Comment 15

[R.K.Aa.]

*** Bug 67653 has been marked as a duplicate of this bug. ***

Comment 16

[Doron Rosenberg (IBM)]

*** Bug 67659 has been marked as a duplicate of this bug. ***

Comment 17

[R.K.Aa.]

*** Bug 67701 has been marked as a duplicate of this bug. ***

Comment 18

[R.K.Aa.]

*** Bug 67791 has been marked as a duplicate of this bug. ***

Comment 19

[Gilles Durys]

*** Bug 67823 has been marked as a duplicate of this bug. ***

Comment 20

[R.K.Aa.]

*** Bug 67835 has been marked as a duplicate of this bug. ***

Comment 21

[Asa Dotzler [:asa]]

hyatt, we're wrapping up 0.8 rsn.  Any chance this will make it? Is this related
to the problem at bug 67435?  They both seem to have started about the same time.  
This is causing crashes in several places, bookmarks, history, editor, sidebar.   

Comment 22

[R.K.Aa.]

*** Bug 67863 has been marked as a duplicate of this bug. ***

Comment 23

[R.K.Aa.]

*** Bug 67910 has been marked as a duplicate of this bug. ***

Comment 24

[R.K.Aa.]

It's raining dups -> mostfreq

Comment 25

[Asa Dotzler [:asa]]

This appears to be fixed!  Is this ia result of checkin fixing bug 67435 or am I
just smoking crack again?

Comment 26

[Asko Tontti]

PC Linux 2001020706:

No more crash in Manage Bookmarks (CTRL-B) window and Bookmarks on Sidebar.

But now right clicking any Bookmarks on Sidebar show empty popup menu
with error:

JavaScript error: 
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/nsTreeUtils.js :: get_localized_string :: line 502" 
data: no]

Comment 27

[djk]

I get the same symptom (empty Sidebar Bookmark context menu) and javascript
exception running build 2001020704 on Win98se.

Comment 28

[Gilles Durys]

*** Bug 68020 has been marked as a duplicate of this bug. ***

Comment 29

[Blake Ross]

Yes, this was fixed with 67435.  The problem with the bookmarks panel is 
separate, and is simply that Ben hasn't yet hooked it up to work with the new 
code; that's a .9 task, and isn't going to be fixed for .8.  Marking fixed, 
please split off a separate bug for the Bookmarks panel context menu problem.

Comment 30

[Blake Ross]

Bugzilla problelm with resolution, reopening, remarking fixed.

Comment 31

[Blake Ross]

Fixed.

Comment 32

[Asko Tontti]

Empty context menu -> bug 68018.

Comment 33

[R.K.Aa.]

Blake: At the time this bug and bug 67435 surfaced, context-menu's in sidebar
were hooked up. I won't insist they worked 100%, but i saw them. Bug 68018 is a
regression.

Comment 34

[Blake Ross]

I know.  They are separate bugs.  Ben knowingly broke some stuff involving the 
bookmarks sidebar with his .8 bookmarks checkin.  They'll be fixed in .9.

Comment 35

[greer]

This stack is showing up again in M092 with comments similar to those previous:

(32616641)  Comments: opening and closing folders while browsing the filesystem 
tree!!It keeps crashing! it is very repeatable: just click on
an arrowto close a folder and then double click on a folder
     (32504498) Comments: Browsing bookmarks menu
     (32501876) URL: www.alsa-project.org
     (32501876) Comments: waiting for page to load
     (32449406) Comments: paging through a search
     (32411481) URL: www.google.com
     (32411481) Comments: searching

Reopening and adding topcrash keyword and signature for tracking. cc'ing 
talkback.

Comment 36

[John Morrison]

I think it is just wrong to be reopening this bug. This was a specific 
regression that arrived in the evening of Feb 1st, and was fixed Feb 6th,
with many, many duplicates reported during that time, and none after the 
fix went in. The steps to reproduce were very specific (in this bug at least)
and, if I recall correctly, this was a very "hot" bug that went completely
cold after the fix. 

There may well be some lingering corner case that is related to this fix, 
and it would be instructive to mention this earlier incarnation, but really
it's a better idea to file a separate bug and don't morph this one. 

Comment 37

[John Morrison]

verified for the original report.