Closed Bug 68018 Opened 23 years ago Closed 23 years ago

Sidebar/Bookmarks: right click menu is still tiny & empty

Categories

(SeaMonkey :: Sidebar, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: burnus, Assigned: fabian)

References

Details

(Keywords: regression)

Attachments

(4 files)

Mozilla/5.0 (X11; U; Linux 2.2.18 i686; en-US; m18), build 2001020706

Now that bug 67435 is fixed I would like to get a working menu back for the
sidebar bookmarks. (The sidebar/history works: It doesn't show any menu. The
bookmark manager right-click menus work (now) like a charm.)

Observed: A right click in the sidebar/bookmarks produces a 3x5 pixel wide empty
menu.

Expected: The same as if I would right click in the bookmark manager: A fully
working menu.
I see it on win98 2001020704

A small comment to the reporter, you do not need to CC yourself.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
See bug 67427.
I see this too, but hasn't it been like this all the time?

cc'ing ben who are doing bookmark stuff...
Cc ben, bookmarks owner.

This is a regression: bookmark sidebar context menu used to have
- new bookmark, new folder, new separator
- delete bookmark
- properties...
- (for folders) set as [new bookmark, new internet search, personal toolbar] 
folder
Keywords: regression
Mozilla 0.8
Mozilla/5.0 (Windows; U; WinNT4.0; en-US; 0.8) Gecko/20010215

Similar problem, i.e. no context menu in bookmarks sidebar, but I don't see a
3x5 empty menu, I see nothing.  I coulda sworn this was working in 0.7.
*** Bug 69093 has been marked as a duplicate of this bug. ***
The part that empty menus are tiny is bug 33723.
*** Bug 69571 has been marked as a duplicate of this bug. ***
*** Bug 69692 has been marked as a duplicate of this bug. ***
Attached patch partial fixSplinter Review
I made a partial fix that restores Properties menuitem if there is
any use for it. It also does some clean up to bookmarks.properties file.
Why does it remove the ellipsis ("...") on some of the strings? Those are there
for a purpose;

if the user needs to do any input after choosing that action, like Print (you
need to press "Print" in the new dialog to print), there should be an ellipsis.

If on the other hand, the user doesn't need to do anything in order to execute
that action (i.e Find Again) then it shouldn't have an ellipsis.

Please reconsider some of those string changes.. thanks.
I removed ellipsis from Rename because it doesn't open a new dialog window in
Bookmark Manager.

But if the new dialog window is not the issue but the additional keyword
interaction then you are right it should have the ellipsis.
s/keyword/keyboard/
leave the ellipsis of properties.
*** Bug 70679 has been marked as a duplicate of this bug. ***
ben owns sidebar bookmarks.
Assignee: matt → ben
Sidebar's bookmarks seems to be fixed (rewritten) in trunk so I updated the
patch. It fixes the ellipsis of cmd_properties and removes redundant cmd_rename.
This bug is fixed, it seems. If you don't create a new profile: edit your
existing profile's panels.rdf and change the bm-panel.xul to bookmarksPanel.xul
WFM.
You can also fix current profile like this.

  1. Select My Siderbar: Tabs: Customize My Siderbar...
  2. Remove Bookmarks from Tabs
  3. Add bookmarks to Tabs

Should I open a new bug for the bookmark.properties patch?
On my system (2001031304) this bug is fixed with respect to the context menu
appearing on right click. But the menu is not working, e.g. nothing happens when
clicking on "properties"
WFM with Linux build. Properties dialog also appears.
WFM too on winNT, build 2001-03-16
Opened a new bug 72798 for the bookmark.properties patch.
Is there a bug on the bookmarks context menu not doing anything?
(Most items are perm disabled - those who aren't don't work.)
I had this bug, but it seems to be working okay for me now (since at least build
20010312??, for Win98SE).
the menu comes up OK, but nothing does anything (2001-03-30) - another bug?
time to close this bug? (wfm with PC Linux 2001041505)
Marking worksforme as per user comments.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
verified in 4/12 build.
Status: RESOLVED → VERIFIED
Reopening : I'm seeing this again with 2001041805 linux
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
Gilles, are you seeing that the context menu is tiny & empty (the original bug),
or are some of the menu items non-functional (which should be a different bug)?
This has regressed at today's build (PC Linux 2001041805):

*** BAD! EVIL! WICKED! NO! ACK! ARGH! ORGH!
JavaScript error: 
chrome://communicator/content/bookmarks/bookmarksOverlay.js line 272: aNodeID is
not defined

Oliver: I see a tiny and empty context menu
*** Bug 77407 has been marked as a duplicate of this bug. ***
nominating for nsbeta1. 
Keywords: nsbeta1
Target Milestone: --- → mozilla0.9.1
nsbeta1+, P2.
Keywords: nsbeta1nsbeta1+
Priority: -- → P2
Attaching patch (one-liner)... like someone used to tell me.. "Duh!"
Taking from Ben marking P1, CC'ing reviewers. Please r=/sr=, thanks.
Assignee: ben → hidday
Status: REOPENED → NEW
Keywords: patch, review
Priority: P2 → P1
r=doron
sr=alecf
if fabian needs cvs help/access, reassign this bug to me and I can check changes in.
That's very kind of you, but hwaara already volunteered to check them in once
the tree opens. Thanks though :)
Fix checked in. Marking FIXED.
Thanks for the reviews.
Status: NEW → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
currently bookmarks don't even load in the sidebar.

so I can't verify this bug until 71685 is fixed, right?

correct me if I'm wrong...I just tried context menu
in my empty bookmark tab, nothing comes up.

Right nothing will come up if the display is blank. If you have bookmarks in
there the context menu will appear (although the menu items don't work, but
that's another bug).
I'm sorry to hear you are also experience bug 71685 :(
verified in 5/23 build..
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.