Closed Bug 674372 Opened 13 years ago Closed 12 years ago

Add localization support to email preference center

Categories

(www.mozilla.org :: General, defect)

Product:
www.mozilla.org
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: wbowden, Assigned: pascalc)

References

Details

(Whiteboard: [pascalc-Q4],[l10n],)

Attachments

(5 files)

Newsletter Signup in Spanish
25.00 KB, application/msword
Details
Newsletter Signup in Spanish (reviewed)
13.00 KB, application/octet-stream
Details
Bug #1 - Title runs into image
227.29 KB, image/png
Details
Screenshots - first round live
2.08 MB, application/zip
Details
space before !
227.54 KB, image/png
Details 
Please add localization support for our email preference center.  

We would only like to show localized versions of this page for the locales that we are offering localized newsletters in.  Currently those locales are:

English
German
French
Portuguese 
Spanish
Milos or Stas, 

What localization implementation or approach would you like to use for this bug?  Thanks.
Wins
Disregard my last comment, please.
Hi Winston, this one has been a bit delayed on my side as we had a few time consuming projects (State of Mozilla, Firefox Live 2, A/B testing on the download page, various Firefox releases...) sorry about that. 

James rewrote the email preferences backend which we are going to use, I can get back to working on the email preferences center when Firefox Live 2 is out and Firefox 8 are released too, since we have a Mozcamp Europe at the end of the week, that's probably next Monday.
Whiteboard: [pascalc-Q4],[l10n],
Assignee: nobody → pascalc
Pascal, let me know if we need to change anything about the code to make localization easier.
Thanks James, if your code can change days to have 32 hours instead of only 24, I think everybody in my team will adopt it ;) I'l really dig into it next week once the different urgent projects are out and I will tell you if there are specific l10n needs in your code :)
(In reply to Pascal Chevrel:pascalc from comment #6)
> Thanks James, if your code can change days to have 32 hours instead of only
> 24, I think everybody in my team will adopt it ;) I'l really dig into it
> next week once the different urgent projects are out and I will tell you if
> there are specific l10n needs in your code :)

I looked through the code for a few seconds to figure out how I could do that. Then I realized it was impossible. Sorry! :)
Hi all.  Just checking in on the status of this bug.  Most pressing is getting a Spanish version of the subscriber form up.
Hi there - sorry to be a pest - but can I get an update on timing for this bug?
Do I need to do anything here? Pascal, let me know. I think there's just a bunch of strings that need localization.
Pascal, the most critical right now is ES.  We've launched that newsletter and would like to start marketing it more aggressively.  We need the sign up page translated into ES in order to do that.
Hi all. Yes, Winston is right. We would like to make some campaigns to get subscribers in Mozilla Hispano social networks and we would like to direct people to an ES version of the page. Next newsletter will be launched next december 20th, could it be possible to get this before that date?
I'll see what we can do (maybe an interim solution) à but my team is pretty busy helping engagement and engineering with many l10n projects, all of them of high priority (New download pages for all locales, firefox flicks, affiliates, mozillians, new home page snippets, 3.6 upgrades, mobile support, several new locales...).
Thanks for your answer Pascal. If it's finally impossible for you in this month, what about January? I guess next newsletter would be launched in mid-January, could it be possible for that date?
Hey all, I'm attaching the Spanish version of the sign up page here. If there is something missing, please let me know.

Thanks for the update, Pascal,. With this information on hand, can you give us a timeline for when your team can work this in?

Thanks!
Hi all!

@Jess, thanks for attaching the Spanish localization of the sign-up page. We really appreciate that, but we reviewed the file and found some translation mistakes that should be urgently corrected. Would it be ok for you if we did that ourselves?

Best.
Inma, 

That would be fantastic!  Thank you. Please just attach the new file to this bug when it is ready.

Cheers
We made a few changes in the translation to make it sound more natural and neutral. The file is attached.
Attachment #582458 - Attachment filename: SpanishNewsletterSignup.doc.doc → SpanishNewsletterSignup.doc
Hi!

Any update on this? We would like to have this active in the Spanish version of the January newsletter.

Thanks!
Hi there -- chiming in here. 

Pascal / Stas / Milos: can you help us with a timeline for this please. The bug has been open since more than 6 months. As said, Spanish is currently the most important.

Understand things are very busy, a time estimate should be possible. 

thanks for your help. 
Jane
Target Milestone: --- → Future
Hi - 

Any update?  This should be pretty simple at this point for ES.  The Spanish translation is uploaded.  The only other piece that needs to be translated is the confirmation message one receives after subscribing. 

-
Thanks for Subscribing!
We look forward to soon begin sharing tips & tricks on getting the most out of Firefox, as well as exciting news about Mozilla and how we’re working to create a better Web.
-

This should behave the same way as our german opt-in process.  https://www.mozilla.org/de/newsletter/
Hi all!

Thanks for providing this other piece of text that remained untranslated. Here is our translation:

_
¡Gracias por suscribirte!
Estamos deseando empezar a compartir contigo consejos y trucos sobre cómo sacar el máximo partido de Firefox, las noticias más increíbles sobre Mozilla y todo el trabajo que hacemos para crear una Web mejor.
_

Great news that this is moving forward at last!
Jane, this bug is for the localization of the whole email preference center. It is a long term project with many aspects (many locales, many pages per locale, several newsletters which can be added/removed dynamically, privacy aspects, code and design...). 
The specific request in the last comments of this bug is for a newsletter page in Spanish which is a small subset of this project, this is done on trunk, it needs a bit of testing tomorrow and a couple of visual adjustments before I push that to production (probably tomorrow as well):
https://www-dev.allizom.org/es-ES/newsletter/
This is great! Thank you, Pascal. I will test shortly and keep you posted.
Pascal & Winston,

I have run into a few bugs. I'm not 100% sure if these items are something that must be changed on the webdev end or something Winston would need to help set up in Responsys.

1) See attached screenshot - the formatting of the main page's title runs into the image.

2) I signed up with the email address "jessilynkdavis+es@gmail.com" - the web pages looked great, but:

* the "MOZILLA_AND_YOU_FLG" was set to N for my new subscriber. This should be set to Y.

* the Spanish Welcome email ("Spanish_welcome.htm) should be sent via responsys - not the English welcome email


The MOZILLA_AND_YOU_FLG is a dealbreaker to push this live tomorrow. (If the FLG isn't set to Y, they are not subscribed to the newsletter).

Please let us know what the next steps are to fix these bugs.

Thanks!
Jessilyn, the title is fixed, (part of the needed visual adjustments I mentionned in comment #24)

The flag is the same as for other localized newsletters:

<input type="hidden" name="mozilla-and-you" value="Y" />

Which translates into these parameters:
/?mozilla-and-you=Y&email=pascal.chevrel%40free.fr&country=es&lang=es-ES&format=html&privacy=on&submit=¡Suscríbeme!

I don't know which parameters your web service is expecting for the $country and $lang variables, currently we are using mozilla.org standard locale codes but my guess is that either the newsletter is not activated in Spanish in responsys or it is expecting non-standard locale/country codes for Spanish and is falling back to the English version.
Jess, we've setup all international forms to be opt-in, meaning they are sent an email and are required to click a link to complete the signup. This is in response to certain privacy laws in Europe.

Let us know if this shouldn't be the case for Spanish. Pascal, if it doesn't need to be optin, change this line:

$form->save_new(array('optin' => FALSE));

to something like:

if($lang == 'es-ES') {
  $form->save_new();
}
else {
  $form->save_new(array('optin' => TRUE)); 
}
Also, all of the welcome emails are sent from Responsys, so please work with with Winston on that.
Winston, can you check on your side please? Is the newsletter in Spanish activated in Responsys? Thanks
Hi Pascal, Winston and I looked into it yesterday and have the action items on our/Responsys end to hopefully implement today. We will keep you posted. Thank you to you and James for your help on this project.
Per comment 29 - no code change needed.  Should function as it's already laid out.
All looks great and is operating as it should on https://www-dev.allizom.org/es-ES/newsletter/

Please make sure that these Spanish speaking countries are also able to reach the Spanish version (in addition to Spain - es):

Argentina - ar
Bolivia - bo
Chile - cl
Colombia - co
Costa Rica - cr
Cuba - cu
Dominican Republic - do
Ecuador - ec
El Salvador - sv
Guatemala - gt
Honduras - hn
Mexico - mx
Nicaragua - ni
Panama - pa
Paraguay - py
Peru - pe
Puerto Rico -pr
Uruguay - uy
Venezuela - ve

Is it possible to make this live by Wednesday 1/25?

Thanks!
I can make it live today if you wish. We don't do geolocation on mozilla.org, I can make sure we have pages up for the other Spanish locales we support (es-CL, es-AR, es-MX) but geotargetting people is not something we can do today on this site. I have changed the code to also work with a neutral locale code URL if you want to use it (on submitting the form, the es-ES version is loaded):

https://www-dev.allizom.org/es/newsletter/
Thanks Pascal.  Before we go live we need confirmation from Winston that this behavior is okay:

The way it will currently work when this goes live (from my testing):

If someone goes to https://www.mozilla.org/es/newsletter (which will be anyone coming from a spanish speaking locale), their "LanguageISO_2" field will be "es-ES" and their "Language_Locale_" will be "es-ES"  

If they indicated their country is Mexico, their "country_" field will be "mx"


Winston, is this okay?
As long as we're collecting country code, this works great.  Thanks all.
Awesome - I think we're ready to push live! Pascal, can we make this live on Monday? (just in case something goes wrong, we don't wait a weekend to find it)

I think having the neutral locale code URL is great. That way anyone who visits the page from a Spanish speaking country will be able to see the newsletter sign up form.

Please let me know if you have any questions. Please also let me know when this will go live so I can be prepared to test as soon as it is live.

Thanks!

Jess
This is pushed to production in r100264 (es-ES newsletter plus the code cleanup needed to remove duplicate or old code and have a more scalable solution to add more locales)
This is great, Pascal! Thank you so much!  I tested it out this morning and all looks great.

Thank you also for the code-cleanup to make the solution more scalable. We have plans to launch 10 more locales in 2012.

Now that I've fully hijacked this ticket - Winston, do you want to revisit the original plan for this ticket to localize the email preference center?
Thanks for pushing Spanish.  Is this just the front end sign up page, or does this also include the preference center portion where the user can edit / change their profile options.  

Also - can we make a goal to have the back end preference center component localized asap?  We're in the process of switching email vendors and it will be necessary to have this functionality in place prior to going live end of February.  That would mean the following would need to be localized:

DE, FR, PT-BR, ES
Severity: normal → major
Hi Pascal,

Can you provide an update please per comment 42?  It's important that we develop a timetable for knocking this out prior to the end of February.
(In reply to Winston Bowden from comment #42)
> Thanks for pushing Spanish.  Is this just the front end sign up page, or
> does this also include the preference center portion where the user can edit
> / change their profile options.  
> 
> Also - can we make a goal to have the back end preference center component
> localized asap?  We're in the process of switching email vendors and it will
> be necessary to have this functionality in place prior to going live end of
> February.  That would mean the following would need to be localized:
> 
> DE, FR, PT-BR, ES

I don't think it is feasible for end of February, end of March looks like a more realistic target to me.
Thanks for the update, Pascal.

The March deadline will work for the backend portion.  But it’s critical that we have this functioning by then.  If we don’t, we will be unable to communicate with our non-en subscribers. 

One piece that can’t wait until March is the process for opt-ing in new subscribers.  Most of that is already set up – but we need a confirmation page that lets them know they’ve been added to the list.  I’m submitting a new bug for this piece (721904). It's already been translated.  To ensure we remain legally compliant, we'll need this set before the end of February.
Hi Pascal - I'd like to set March 19 as the deadline for finalizing back end localization of the preference center for our current locales.  Can you reply with confirmation that this works?
It should be ok
Hey Pascal,

I wanted to touch base about this project for these 4 locales and future locales. (Let me know if I should make this another bug.)

I am working with community volunteers to localize the Newsletter content each month. If it is helpful, I am more than happy to send them the Preference Center strings in English to localize into PT-BR, ES, FR, and DE.  Just let me know.

With this said, when we launch new locales in the near future, would it be useful to get our newsletter localizers to localize these preference center strings?
More volunteers never hurts :)
awesome :)

Is there a central place you have the English strings stored that I can point them to? Or should I send the teams the strings in a google doc (how I currently work with them on the newsletter)

Awhile back, I pulled the English strings that I could see and put them into a google doc - but I may be missing pieces (most notably error messages).
https://docs.google.com/spreadsheet/ccc?key=0AmYFYnxC9euxdElCOVZwbC1OR29iSDRDSVcyempQV3c#gid=0
Hi Pascal - how's this coming along?  Also - how will this be impacted by code freeze?  We had set a deadline of the 19th - but that was before we realized a code freeze would occur on the 15th.  We need the localized version of the preference center live for our March email mailing on March 28.
Blocks: 733938
Hi pascal - ping on an update?
I am working on it, I should have something on dev server mid-next week
Awesome.  Thank you!
Current state:
https://www-dev.allizom.org/de/newsletter/new/
https://www-dev.allizom.org/fr/newsletter/new/

The page basically works and I have localizers working on the translation. I need to work on that a couple more days before we can do QA on it.
Thanks, Pascal.  These are looking great.  I wanted to confirm that you also have the "existing" subscriber page on your radar as well.  It's the piece that allows the user to unsubscribe from a mailing.
Yes, it's on my radar.
Hi Pascal - can you provide a quick status update?  We're sending to these subscribers this week and will need everything wrapped up prior to Friday.
Any update?
Piling on here -- please can you give us a day / time when this will be completed? Its hard to operate/plan without concrete info. Thanks for your help.
pascal is out on pto,  milos is checking up on status of checkins by localizers.
Winston, Jane,

I don't know much about this, but this is what I see on dev server and in this bug:

* We need following locales: de, es, fr, pt-BR.
* For all the locales we have files in place plus files for Hungarian(hu)
** German(de) and Hungarian(hu) have this page fully translated
** Spanish(es-ES) and Portuguese Brazilian(pt-BR) have only one string not translated ("Subscribe")
** French has several untranslated strings
* es-AR, es-CL and es-MX are not redirecting to es-ES, but to en-US.

Can you tell me when do we need this for and whether we need redirects for all Spanish languages to Spanish in Spain(es-ES)? Also, under /newsletter/ namespace on mozilla.org, I see a few other files, which are probably used somewhere else than https://www-dev.allizom.org/ab-CD/newsletter/new/ - what do we know about that?

Aside from that, none of the aforementioned languages have translated sharing links("Follow us" and "Like us" for Twitter and Facebook, respectively). Is that something that we don't want translated?

Once you provide me with that info, I can go ahead and ping localizers to finish up this pages.
I am just back from PTO and catching up. French is done. I am working on the templates for confirmation messages now, if all goes well we should have that ready this afternoon (Pacific time).
The newsletter center is localized in the locales we have newsletters for, we can add locales later.

https://www.mozilla.org/de/newsletter/new/
https://www.mozilla.org/de/newsletter/existing/
https://www.mozilla.org/de/newsletter/updated/

AFAICT, this works correctly.
Spanish is fully localized too. At revision: 103516 (Pascal already knows about this because I just pinged him on Twitter)

Best,
Hey Pascal,

Bringing the latest back into this bug.

Thanks for pushing live so we can see them in action.  A few visual bugs - I still need to go through and test functionality. I'm including screenshots so you can see what I see on these pages.

/new/ :
(All - FR, PT-BR, ES-ES, DE) 
Need default language to be the language that they signed up with (not English) - otherwise, if they do not change their language drop down info, their profile will change to English.

/existing/ :
(All - FR, PT-BR, ES-ES, DE) 
Form is missing like on EN page
"Manage your Newsletter Subscriptions" needs to be translated

/updated/ :
(PT-BR, ES-ES)
"Thanks for updating your email preferences" needs to be translated


I'm testing functionality of the /new/ page now and will keep you updated.

Thanks!
Per comment above - screenshots of each locale's /new/, /existing/, and /updated/ pages
Technical bugs:

/new/:
https://www.mozilla.org/es-ES/newsletter/new/ is passing "es" as the LanguageISO2 field. It should be "es-ES"


Additional technical:
/es/ can be retired - we only need /es-ES/

In response to Milo's comment above:
any "es" locale (es-AR, es-CL, and es-MX) should be redirecting to es-ES
(In reply to Jessilyn Davis from comment #67)

> /new/ :
> (All - FR, PT-BR, ES-ES, DE) 
> Need default language to be the language that they signed up with (not
> English) - otherwise, if they do not change their language drop down info,
> their profile will change to English.
> 

Fixed in r103532, if we don't have information stored for the preferred locale, it uses the page locale as the default locale in the form.
> 
> /existing/ :
> (All - FR, PT-BR, ES-ES, DE) 
> Form is missing like on EN page

The form appears only for English or locales if you have a valid unsubscription token in the URL. On the dev site, there is a "debug" parameter to force the display of the form to check it:
https://www-dev.allizom.org/pt-BR/newsletter/existing/?debug


> "Manage your Newsletter Subscriptions" needs to be translated
fixed in r103533
 
> /updated/ :
> (PT-BR, ES-ES)
> "Thanks for updating your email preferences" needs to be translated

Already fixed on the staging site with the updated .lang files our localizers provided, it just needs a push to production.
> /new/:
> https://www.mozilla.org/es-ES/newsletter/new/ is passing "es" as the LanguageISO2 field. It should be "es-ES"

fixed in r103534
> any "es" locale (es-AR, es-CL, and es-MX) should be redirecting to es-ES

newsletter/ and newsletter/new are now redirected to es-ES in r103535
All changes requested + updated translations are on production in r103537
(In reply to Pascal Chevrel:pascalc from comment #71)
> > 
> > /existing/ :
> > (All - FR, PT-BR, ES-ES, DE) 
> > Form is missing like on EN page
> 
> The form appears only for English or locales if you have a valid
> unsubscription token in the URL. On the dev site, there is a "debug"
> parameter to force the display of the form to check it:
> https://www-dev.allizom.org/pt-BR/newsletter/existing/?debug
> 
> 
> > "Manage your Newsletter Subscriptions" needs to be translated
> fixed in r103533

I'm using a valid user token, but I can't get it to appear:
https://www.mozilla.org/es-ES/newsletter/existing/6d24dfa2-388a-4e02-8863-d4033a197cab/
(In reply to Pascal Chevrel:pascalc from comment #70)
> (In reply to Jessilyn Davis from comment #67)
> 
> > /new/ :
> > (All - FR, PT-BR, ES-ES, DE) 
> > Need default language to be the language that they signed up with (not
> > English) - otherwise, if they do not change their language drop down info,
> > their profile will change to English.
> > 
> 
> Fixed in r103532, if we don't have information stored for the preferred
> locale, it uses the page locale as the default locale in the form.

Beta should only show for EN (for es-ES - ES is selected by default - but Beta shows)
/existing/?debug :
(all locales)
default language should be the locale
ES needs to be added to drop down
Beta is only available for EN
Attached image space before ! — 
Extra space before the ! that puts the ! on a different line. Can we make the ! on the same line?
(In reply to Pascal Chevrel:pascalc from comment #73)
> > /new/:
> > https://www.mozilla.org/es-ES/newsletter/new/ is passing "es" as the LanguageISO2 field. It should be "es-ES"
> 
> fixed in r103534

https://www.mozilla.org/es-ES/newsletter/new/ is not passing information to Exact Target (no new contact is added when form is submitted; it works for de, fr, pt-BR)
(In reply to Jessilyn Davis from comment #76)
> (In reply to Pascal Chevrel:pascalc from comment #71)
> > > 
> > > /existing/ :
> > > (All - FR, PT-BR, ES-ES, DE) 
> > > Form is missing like on EN page
> > 
> > The form appears only for English or locales if you have a valid
> > unsubscription token in the URL. On the dev site, there is a "debug"
> > parameter to force the display of the form to check it:
> > https://www-dev.allizom.org/pt-BR/newsletter/existing/?debug
> > 
> > 
> > > "Manage your Newsletter Subscriptions" needs to be translated
> > fixed in r103533
> 
> I'm using a valid user token, but I can't get it to appear:
> https://www.mozilla.org/es-ES/newsletter/existing/6d24dfa2-388a-4e02-8863-
> d4033a197cab/

I just got it to work on dev:
https://www-dev.allizom.org/fr/newsletter/existing/cfa06343-b2e5-4c33-9132-b2b95b21166e/

Bug found:
1) Language needs to be preset to be of the locale in the URL

I'll have to test how the form works on prod once it's pushed (we can push live whenever on this part since no one can get to it w/o the link from the email)
> /existing/?debug :
> (all locales)
> default language should be the locale

fixed in rr103544

> I'm using a valid user token, but I can't get it to appear:
https://www.mozilla.org/es-ES/newsletter/existing/6d24dfa2-388a-4e02-8863-d4033a197cab/

r103542 might fix it but we will know only when it is pushed to production, our staging server doesn't allow using the tokens

>Extra space before the ! that puts the ! on a different line. Can we make the ! on the same line

That's fixed in r103545

>https://www.mozilla.org/es-ES/newsletter/new/ is not passing information to Exact Target (no new contact is added when form is submitted; it works for de, fr, pt-BR)
+
>Beta should only show for EN (for es-ES - ES is selected by default - but Beta shows)

This is because of the requested change to use es-ES instead of es for Spanish code, there was a reference to it in James' emailPrefs library, I changed it in r103546 to use es-ES now.

I am going to merge all these changes to production so as that we can test the token
pushed to production in r103548, you can test again when you see that the exclamation mark for Spanish is on the same line as the text, it will mean that the site will have updated itself.
Awesome - testing things now. Thanks Pascal!

One quick bug I just spotted:
https://www.mozilla.org/fr/newsletter/existing/cfa06343-b2e5-4c33-9132-b2b95b21166e/

The email address should be pre-populated like:

https://www.mozilla.org/en-US/newsletter/existing/cfa06343-b2e5-4c33-9132-b2b95b21166e/
Subscription FLGs should also be prepopulated so that people can see what lists they are currently subscribed to.  (I think that's related to Comment 84 above)
I am looking for #84/#85 but haven't found why it doesn't work yet, I will probably have to send some debug code to allizom.org to compare en-US and locales behaviour
(In reply to Pascal Chevrel:pascalc from comment #86)
> I am looking for #84/#85 but haven't found why it doesn't work yet, I will
> probably have to send some debug code to allizom.org to compare en-US and
> locales behaviour

Awesome - this is the last piece we need working in order to send the newsletter.  Keep us posted.  Thank you for hard work on this today.

Absolute final deadline for this piece to be perfect on production:
3/29 3pm PDT  
(the earlier the better of course - especially given the timezones and the human need for rest :) )

Thanks again
I have the email prefilling working now (on the technical side, there is a creative use of constructors in one of our classes, we use an empty $POST array to initialize a variable as NULL and that NULL variable is setting a public variable as an empty array, that's the kind of things hard to debug :) ). I am removing the debug code and pushing that fix to production now.
awesome! I can't wait for it to populate so I can see the magic! :-D  Keep me posted when the changes have taken effect
BEAUTIFUL! <3

I'm going to check again first thing in the am to make sure I havent missed anything.

Thanks Pascal!
cool, I am going to bed then, ttyt :)
Everything looks perfect this morning!

Closing this bug out. We'll open new bugs for any minor tweaks and updates now that this is live.

Thanks again for your hard work yesterday to get this up and working.
cool, marking fixed then :)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: www.mozilla.org/firefox → www.mozilla.org
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: